From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159954-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 53438 invoked by alias); 22 Oct 2019 08:52:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 53333 invoked by uid 89); 22 Oct 2019 08:52:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 08:52:23 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 01ADB20293; Tue, 22 Oct 2019 04:52:21 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca])	by mx1.osci.io (Postfix) with ESMTP id 4138420176;	Tue, 22 Oct 2019 04:52:21 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 35F312192E;	Tue, 22 Oct 2019 04:52:21 -0400 (EDT)
X-Gerrit-PatchSet: 1
Date: Tue, 22 Oct 2019 08:52:00 -0000
From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] [RFC][gdb] Make script-extension strict reject unknown extensions
X-Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576
X-Gerrit-Change-Number: 40
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40>
X-Gerrit-Commit: b625d8dd1120db265f4681faa2b4848197187899
In-Reply-To: <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Tue, 22 Oct 2019 04:52:21 -0400
Reply-To: tdevries@suse.de, cbiesinger@google.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191022085221.35F312192E@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00786.txt.bz2

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > A couple questions about this:
> > > - If specified in -ix or a system gdbinit file, does it prevent reading ~/.gdbinit?
> [...] 
> > But for the system gdbinit, it's yes.
> > 
> > > - Does it prevent reading a file in --command if it doesn't have the extension?
> > 
> > Yes:
> [...]
> 
> Hm, personally I would find that behavior surprising, especially for the gdbinit file. But I have no decision power here...

Fixed in patch set 2.