From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Konrad Kleine <kkleine@redhat.com>
Subject: [review] [gdb] Fix typos in comments
Date: Thu, 17 Oct 2019 10:20:00 -0000 [thread overview]
Message-ID: <20191017102035.F011420AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571300237000.I6047967abd2d51c9000dea15184d19f4e952c3ff@gnutoolchain-gerrit.osci.io>
Tom de Vries has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1: Code-Review+1
>
> (1 comment)
>
> LGTM except for a minor question.
Fixed.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c
File gdb/darwin-nat-info.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c@813
PS1, Line 813: /* FIXME: This need a privileged host port! */
> Done
It should, thanks for noticing.
I only did a check for invalid words, not grammar, so I didn't catch this.
Fixed in Patchset 2.
next prev parent reply other threads:[~2019-10-17 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 8:17 Tom de Vries (Code Review)
2019-10-17 10:04 ` Konrad Kleine (Code Review)
2019-10-17 10:16 ` Tom de Vries (Code Review)
2019-10-17 10:18 ` Konrad Kleine (Code Review)
2019-10-17 10:18 ` Konrad Kleine (Code Review)
2019-10-17 10:20 ` Tom de Vries (Code Review) [this message]
2019-10-17 14:59 ` Simon Marchi (Code Review)
2019-10-17 16:07 ` Sourceware to Gerrit sync (Code Review)
2019-10-17 16:07 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017102035.F011420AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=kkleine@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox