Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Konrad Kleine (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: [review] [gdb] Fix typos in comments
Date: Thu, 17 Oct 2019 10:18:00 -0000	[thread overview]
Message-ID: <20191017101756.CA5A720AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571300237000.I6047967abd2d51c9000dea15184d19f4e952c3ff@gnutoolchain-gerrit.osci.io>

Konrad Kleine has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130
......................................................................


Patch Set 2:

(1 comment)

Thanks for incorporating my suggestion.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c 
File gdb/darwin-nat-info.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c@813 
PS1, Line 813: 	  /* FIXME: This need a privileged host port!  */
> Shouldn't it say "This needs a privileged host port!" ?
Done




  parent reply	other threads:[~2019-10-17 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  8:17 Tom de Vries (Code Review)
2019-10-17 10:04 ` Konrad Kleine (Code Review)
2019-10-17 10:16 ` Tom de Vries (Code Review)
2019-10-17 10:18 ` Konrad Kleine (Code Review) [this message]
2019-10-17 10:18 ` Konrad Kleine (Code Review)
2019-10-17 10:20 ` Tom de Vries (Code Review)
2019-10-17 14:59 ` Simon Marchi (Code Review)
2019-10-17 16:07 ` Sourceware to Gerrit sync (Code Review)
2019-10-17 16:07 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017101756.CA5A720AF6@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=kkleine@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox