From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159731-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 34556 invoked by alias); 17 Oct 2019 10:20:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 34545 invoked by uid 89); 17 Oct 2019 10:20:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2019 10:20:39 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id C4F0F208F2; Thu, 17 Oct 2019 06:20:37 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca])	by mx1.osci.io (Postfix) with ESMTP id 1D0A8204E6;	Thu, 17 Oct 2019 06:20:36 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id F011420AF6;	Thu, 17 Oct 2019 06:20:35 -0400 (EDT)
X-Gerrit-PatchSet: 2
Date: Thu, 17 Oct 2019 10:20:00 -0000
From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Konrad Kleine <kkleine@redhat.com>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] [gdb] Fix typos in comments
X-Gerrit-Change-Id: I6047967abd2d51c9000dea15184d19f4e952c3ff
X-Gerrit-Change-Number: 130
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130>
X-Gerrit-Commit: 549177cd7a8c3756dfa752414765136adc2ef293
In-Reply-To: <gerrit.1571300237000.I6047967abd2d51c9000dea15184d19f4e952c3ff@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571300237000.I6047967abd2d51c9000dea15184d19f4e952c3ff@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Thu, 17 Oct 2019 06:20:35 -0400
Reply-To: tdevries@suse.de, kkleine@redhat.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191017102035.F011420AF6@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00563.txt.bz2

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1: Code-Review+1
> 
> (1 comment)
> 
> LGTM except for a minor question.

Fixed.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c 
File gdb/darwin-nat-info.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/130/1/gdb/darwin-nat-info.c@813 
PS1, Line 813: 	  /* FIXME: This need a privileged host port!  */
> Done
It should, thanks for noticing.

I only did a check for invalid words, not grammar, so I didn't catch this.

Fixed in Patchset 2.