From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Kevin Buettner <kevinb@redhat.com>
Subject: [PATCH v2 0/5] Non-contiguous address range bug fixes / improvements
Date: Thu, 04 Jul 2019 04:55:00 -0000 [thread overview]
Message-ID: <20190704045503.1250-1-kevinb@redhat.com> (raw)
This five part series fixes some bugs associated with GDB's non-contiguous
address range support.
Differences from v1 can be summarized as follows:
- Big block of code in stack.c which handled "certain pathological cases"
was removed entirely. Both Tom and Pedro suggested this change.
- Changes to printcmd.c split out into separate patch; patch expanded
to allow use of data associated with minimal symbol in certain (rare)
cases. (But perhaps not especially rare when dealing with
non-contiguous address ranges.)
- Commit log for negative offset patch expanded with better examples.
- Tests revised slightly to not fail due to change in functionality.
I see no regressions when testing on F30 / x86_64.
Kevin Buettner (5):
Prefer symtab symbol over minsym for function names in non-contiguous
blocks
Restrict use of minsym names when printing addresses in disassembled
code
dwarf2-frame.c: Fix FDE processing bug involving non-contiguous ranges
Allow display of negative offsets in print_address_symbolic()
Improve test gdb.dwarf2/dw2-ranges-func.exp
gdb/disasm.c | 12 +-
gdb/dwarf2-frame.c | 8 +-
gdb/printcmd.c | 33 +-
gdb/stack.c | 71 +-
...anges-func.c => dw2-ranges-func-hi-cold.c} | 44 +-
.../gdb.dwarf2/dw2-ranges-func-lo-cold.c | 82 +++
gdb/testsuite/gdb.dwarf2/dw2-ranges-func.exp | 693 ++++++++++--------
gdb/valprint.h | 13 +-
8 files changed, 542 insertions(+), 414 deletions(-)
rename gdb/testsuite/gdb.dwarf2/{dw2-ranges-func.c => dw2-ranges-func-hi-cold.c} (85%)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-ranges-func-lo-cold.c
--
2.21.0
next reply other threads:[~2019-07-04 4:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 4:55 Kevin Buettner [this message]
2019-07-04 4:55 ` [PATCH v2 2/5] Restrict use of minsym names when printing addresses in disassembled code Kevin Buettner
2019-07-19 17:07 ` Pedro Alves
2019-07-04 4:55 ` [PATCH v2 1/5] Prefer symtab symbol over minsym for function names in non-contiguous blocks Kevin Buettner
2019-07-04 5:03 ` Kevin Buettner
2019-07-04 4:55 ` [PATCH v2 3/5] dwarf2-frame.c: Fix FDE processing bug involving non-contiguous ranges Kevin Buettner
2019-07-04 5:05 ` [PATCH v2 4/5] Allow display of negative offsets in print_address_symbolic() Kevin Buettner
2019-07-30 16:47 ` Kevin Buettner
2019-07-04 5:05 ` [PATCH v2 5/5] Improve test gdb.dwarf2/dw2-ranges-func.exp Kevin Buettner
2019-07-04 5:08 ` Kevin Buettner
2019-07-27 20:48 ` [PATCH v2 0/5] Non-contiguous address range bug fixes / improvements Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704045503.1250-1-kevinb@redhat.com \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox