From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42520 invoked by alias); 4 Jul 2019 04:55:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42308 invoked by uid 89); 4 Jul 2019 04:55:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Big, five X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 04:55:35 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24290307D913 for ; Thu, 4 Jul 2019 04:55:34 +0000 (UTC) Received: from f30-1.lan (ovpn-117-224.phx2.redhat.com [10.3.117.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECAC88351E; Thu, 4 Jul 2019 04:55:33 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Kevin Buettner Subject: [PATCH v2 0/5] Non-contiguous address range bug fixes / improvements Date: Thu, 04 Jul 2019 04:55:00 -0000 Message-Id: <20190704045503.1250-1-kevinb@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00083.txt.bz2 This five part series fixes some bugs associated with GDB's non-contiguous address range support. Differences from v1 can be summarized as follows: - Big block of code in stack.c which handled "certain pathological cases" was removed entirely. Both Tom and Pedro suggested this change. - Changes to printcmd.c split out into separate patch; patch expanded to allow use of data associated with minimal symbol in certain (rare) cases. (But perhaps not especially rare when dealing with non-contiguous address ranges.) - Commit log for negative offset patch expanded with better examples. - Tests revised slightly to not fail due to change in functionality. I see no regressions when testing on F30 / x86_64. Kevin Buettner (5): Prefer symtab symbol over minsym for function names in non-contiguous blocks Restrict use of minsym names when printing addresses in disassembled code dwarf2-frame.c: Fix FDE processing bug involving non-contiguous ranges Allow display of negative offsets in print_address_symbolic() Improve test gdb.dwarf2/dw2-ranges-func.exp gdb/disasm.c | 12 +- gdb/dwarf2-frame.c | 8 +- gdb/printcmd.c | 33 +- gdb/stack.c | 71 +- ...anges-func.c => dw2-ranges-func-hi-cold.c} | 44 +- .../gdb.dwarf2/dw2-ranges-func-lo-cold.c | 82 +++ gdb/testsuite/gdb.dwarf2/dw2-ranges-func.exp | 693 ++++++++++-------- gdb/valprint.h | 13 +- 8 files changed, 542 insertions(+), 414 deletions(-) rename gdb/testsuite/gdb.dwarf2/{dw2-ranges-func.c => dw2-ranges-func-hi-cold.c} (85%) create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-ranges-func-lo-cold.c -- 2.21.0