From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks
Date: Wed, 03 Jul 2019 23:16:00 -0000 [thread overview]
Message-ID: <20190703161648.1438145a@f29-4.lan> (raw)
In-Reply-To: <87pnn05k50.fsf@tromey.com>
On Wed, 26 Jun 2019 11:30:51 -0600
Tom Tromey <tom@tromey.com> wrote:
> >> GDB is prefering this minsym over the the name provided by the
> >> DWARF info due to some really old code in GDB which handles
> >> "certain pathological cases". See the first big block comment
> >> in find_frame_funname for more information.
>
> Pedro> Yuck!
>
> >> I considered removing the code for this corner case entirely, but it
> >> seems as though it might still be useful, so I left it intact.
>
> Pedro> Yeah, I'd be inclined to try removing it too. The comment
> Pedro> smells of a.out or stabs limitations. But I'm not 100% sure,
> Pedro> and I'm sympathetic with forward incremental progress.
>
> That code dates to the creation of the sourceware repository.
>
> I think it could be deleted. And, if it's still a bug somehow, it seems
> better to fix it some other way, and not let stabs and/or a.out
> weirdness into the generic code.
Okay, for v2 of this patch series, I'll get rid of that code.
Thanks,
Kevin
next prev parent reply other threads:[~2019-07-03 23:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 19:55 [PATCH 0/4] Non-contiguous address range bug fixes / improvements Kevin Buettner
2019-06-08 19:55 ` [PATCH 3/4] Allow display of negative offsets in print_address_symbolic() Kevin Buettner
2019-06-21 14:45 ` Pedro Alves
2019-07-03 23:09 ` Kevin Buettner
2019-07-04 1:06 ` Kevin Buettner
2019-06-08 19:55 ` [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks Kevin Buettner
2019-06-21 14:26 ` Pedro Alves
2019-06-26 17:30 ` Tom Tromey
2019-07-03 23:16 ` Kevin Buettner [this message]
2019-06-08 19:55 ` [PATCH 2/4] dwarf2-frame.c: Fix FDE processing bug involving non-contiguous ranges Kevin Buettner
2019-06-21 14:34 ` Pedro Alves
2019-06-08 19:55 ` [PATCH 4/4] Improve test gdb.dwarf2/dw2-ranges-func.exp Kevin Buettner
2019-06-26 17:24 ` [PATCH 0/4] Non-contiguous address range bug fixes / improvements Tom Tromey
2019-07-03 20:10 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703161648.1438145a@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox