Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Non-contiguous address range bug fixes / improvements
Date: Wed, 26 Jun 2019 17:24:00 -0000	[thread overview]
Message-ID: <87tvcc5kf5.fsf@tromey.com> (raw)
In-Reply-To: <20190608195434.26512-1-kevinb@redhat.com> (Kevin Buettner's	message of "Sat, 8 Jun 2019 12:54:30 -0700")

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

Kevin> This four part series fixes some bugs associated with GDB's non-contiguous
Kevin> address range support.

This is not really related to your patches, but since you have been
working in this area, I thought I'd ask.

I ran into a case where gdb will mis-report a breakpoint location in a
certain situation (that is, "info b" will show something odd for the
source location).  After debugging for a while, my theory is that the
problem occurs because the executable has non-contiguous address ranges.

In particular, find_pc_sect_line is written to first find the symtab
with the smallest overall range that encloses the PC, and then to find a
matching symbol in the symtab.  But, with non-contiguous ranges, this
can yield a sub-optimal result -- because the overall range of a symtab
not longer really says anything about whether it holds the best symbol.

Have you seen anything like this?  (I guess not since I'd imagine you'd
have written a patch ;-)

I was thinking perhaps the best fix would be to search the blockvectors
for a definitively enclosing block.  I wonder what you think.

thanks,
Tom


  parent reply	other threads:[~2019-06-26 17:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08 19:55 Kevin Buettner
2019-06-08 19:55 ` [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks Kevin Buettner
2019-06-21 14:26   ` Pedro Alves
2019-06-26 17:30     ` Tom Tromey
2019-07-03 23:16       ` Kevin Buettner
2019-06-08 19:55 ` [PATCH 2/4] dwarf2-frame.c: Fix FDE processing bug involving non-contiguous ranges Kevin Buettner
2019-06-21 14:34   ` Pedro Alves
2019-06-08 19:55 ` [PATCH 3/4] Allow display of negative offsets in print_address_symbolic() Kevin Buettner
2019-06-21 14:45   ` Pedro Alves
2019-07-03 23:09     ` Kevin Buettner
2019-07-04  1:06       ` Kevin Buettner
2019-06-08 19:55 ` [PATCH 4/4] Improve test gdb.dwarf2/dw2-ranges-func.exp Kevin Buettner
2019-06-26 17:24 ` Tom Tromey [this message]
2019-07-03 20:10   ` [PATCH 0/4] Non-contiguous address range bug fixes / improvements Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvcc5kf5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox