From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27290 invoked by alias); 3 Jul 2019 23:16:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27282 invoked by uid 89); 3 Jul 2019 23:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Yeah, limitations X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 23:16:51 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 039413086211; Wed, 3 Jul 2019 23:16:50 +0000 (UTC) Received: from f29-4.lan (ovpn-117-224.phx2.redhat.com [10.3.117.224]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2AF88F6D2; Wed, 3 Jul 2019 23:16:48 +0000 (UTC) Date: Wed, 03 Jul 2019 23:16:00 -0000 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks Message-ID: <20190703161648.1438145a@f29-4.lan> In-Reply-To: <87pnn05k50.fsf@tromey.com> References: <20190608195434.26512-1-kevinb@redhat.com> <20190608195434.26512-2-kevinb@redhat.com> <8f624a5d-58ba-8c6b-064d-9a82a63a6769@redhat.com> <87pnn05k50.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00080.txt.bz2 On Wed, 26 Jun 2019 11:30:51 -0600 Tom Tromey wrote: > >> GDB is prefering this minsym over the the name provided by the > >> DWARF info due to some really old code in GDB which handles > >> "certain pathological cases". See the first big block comment > >> in find_frame_funname for more information. > > Pedro> Yuck! > > >> I considered removing the code for this corner case entirely, but it > >> seems as though it might still be useful, so I left it intact. > > Pedro> Yeah, I'd be inclined to try removing it too. The comment > Pedro> smells of a.out or stabs limitations. But I'm not 100% sure, > Pedro> and I'm sympathetic with forward incremental progress. > > That code dates to the creation of the sourceware repository. > > I think it could be deleted. And, if it's still a bug somehow, it seems > better to fix it some other way, and not let stabs and/or a.out > weirdness into the generic code. Okay, for v2 of this patch series, I'll get rid of that code. Thanks, Kevin