GDB 8.3 release update (2019-03-25)

GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

Hello,

Sorry for the fairly long delay since the last "update" (aka
pre-release). I was busy traveling, and I was also seeing
a fair amount of activity on all the issues being discovered.

To me, it looks like all issues reported for that version
have been fixed?

In terms of bugzilla, there are no open bugs targetting 8.3
at the moment, so we are good on this end too.

If we can confirm there aren't any issues we know of that we want
to fix for 8.3, I could create the release, say, this weekend, or
early next week.

-- 
Joel

Re: GDB 8.3 release update (2019-03-25)

[Eli Zaretskii]

> Date: Mon, 25 Mar 2019 13:43:07 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> If we can confirm there aren't any issues we know of that we want
> to fix for 8.3, I could create the release, say, this weekend, or
> early next week.

All the problems I knew about are fixed, but I wonder whether we need
another pretest, since so many non-trivial changes went in.

Re: GDB 8.3 release update (2019-03-25)

[Sergio Durigan Junior]

On Monday, March 25 2019, Joel Brobecker wrote:

> Hello,
>
> Sorry for the fairly long delay since the last "update" (aka
> pre-release). I was busy traveling, and I was also seeing
> a fair amount of activity on all the issues being discovered.
>
> To me, it looks like all issues reported for that version
> have been fixed?
>
> In terms of bugzilla, there are no open bugs targetting 8.3
> at the moment, so we are good on this end too.
>
> If we can confirm there aren't any issues we know of that we want
> to fix for 8.3, I could create the release, say, this weekend, or
> early next week.

Hi Joel,

There's some ongoing discussion about including:

  [PATCH] Merge handle_inferior_event and handle_inferior_event_1
  https://sourceware.org/ml/gdb-patches/2019-03/msg00475.html

in the 8.3 release.  It's a very simple patch, and I believe Tom/Pedro
won't have any objections to this backport, but I still haven't created
a bug because I'd like to know what Tom thinks about the idea.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: GDB 8.3 release update (2019-03-25)

[Simon Marchi]

On 2019-03-25 4:43 p.m., Joel Brobecker wrote:
> Hello,
> 
> Sorry for the fairly long delay since the last "update" (aka
> pre-release). I was busy traveling, and I was also seeing
> a fair amount of activity on all the issues being discovered.
> 
> To me, it looks like all issues reported for that version
> have been fixed?
> 
> In terms of bugzilla, there are no open bugs targetting 8.3
> at the moment, so we are good on this end too.
> 
> If we can confirm there aren't any issues we know of that we want
> to fix for 8.3, I could create the release, say, this weekend, or
> early next week.
> 

There is this that I would consider quite blocking;

https://sourceware.org/ml/gdb-patches/2019-03/msg00517.html

I haven't checked if the bug appears in 8.3, but I would bet that it 
does, since the patch that caused it was pushed to master and the 8.3 
branch.

In any case, it should be fixed in the coming days.  I will still put an 
entry in the release page on the wiki.

Simon

Re: GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

> > If we can confirm there aren't any issues we know of that we want
> > to fix for 8.3, I could create the release, say, this weekend, or
> > early next week.
> 
> All the problems I knew about are fixed, but I wonder whether we need
> another pretest, since so many non-trivial changes went in.

Yeah, I saw those, and unfortunately saw them too late to raise
a flag. Since they are in, now, might as well keep them. I can
create another pre-release -- but I'll wait for the various issues
identified before doing so. Might as well include those in the next
pre-release.

-- 
Joel

Re: GDB 8.3 release update (2019-03-25)

[Eli Zaretskii]

> Date: Tue, 26 Mar 2019 13:40:42 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > All the problems I knew about are fixed, but I wonder whether we need
> > another pretest, since so many non-trivial changes went in.
> 
> Yeah, I saw those, and unfortunately saw them too late to raise
> a flag. Since they are in, now, might as well keep them.

I didn't mean to say that those changes shouldn't have been admitted.
They all fixed bugs caused by new features in this release.  I just
meant to say that the changes were not trivial, so maybe we have
caused regressions with them.

> I can create another pre-release -- but I'll wait for the various
> issues identified before doing so. Might as well include those in
> the next pre-release.

Right.  Thanks.

Re: GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

Hi Sergio,

> There's some ongoing discussion about including:
> 
>   [PATCH] Merge handle_inferior_event and handle_inferior_event_1
>   https://sourceware.org/ml/gdb-patches/2019-03/msg00475.html
> 
> in the 8.3 release.  It's a very simple patch, and I believe Tom/Pedro
> won't have any objections to this backport, but I still haven't created
> a bug because I'd like to know what Tom thinks about the idea.

Could you backport the patch, and confirm that this helps
hide your issue? I'd like to create a new pre-release as soon
as it is done. As far as I can tell, the issue that Simon reported
is in 8.3 already, so that's the only known issue left.

Thanks!
-- 
Joel

Re: GDB 8.3 release update (2019-03-25)

[Pedro Franco de Carvalho]

Joel Brobecker <brobecker@adacore.com> writes:

> To me, it looks like all issues reported for that version
> have been fixed?

Hello,

There is a regression that affects the release branch and causes some
control characters to be printed infinitely when listing source files
(see <https://sourceware.org/ml/gdb-patches/2019-03/msg00611.html>).
This one isn't fixed.

There is a testsuite issue that was fixed in
<https://sourceware.org/ml/gdb-patches/2019-03/msg00142.html>
(gdb/testsuite: Prepare for DejaGnu 1.6.2), but I haven't seen the
corresponding commit in gdb-8.3-branch.  The commit that causes the
issue is in the branch.  I posted a message in that thread asking if it
makes sense to include it in the release branch.

There is another testsuite issue that was fixed, but the fix doesn't seem
to be in the release branch yet
<https://sourceware.org/ml/gdb-patches/2019-03/msg00613.html>.


Thanks!
--
Pedro Franco de Carvalho

Re: GDB 8.3 release update (2019-03-25)

[Sergio Durigan Junior]

On Tuesday, March 26 2019, Joel Brobecker wrote:

> Hi Sergio,
>
>> There's some ongoing discussion about including:
>> 
>>   [PATCH] Merge handle_inferior_event and handle_inferior_event_1
>>   https://sourceware.org/ml/gdb-patches/2019-03/msg00475.html
>> 
>> in the 8.3 release.  It's a very simple patch, and I believe Tom/Pedro
>> won't have any objections to this backport, but I still haven't created
>> a bug because I'd like to know what Tom thinks about the idea.
>
> Could you backport the patch, and confirm that this helps
> hide your issue? I'd like to create a new pre-release as soon
> as it is done. As far as I can tell, the issue that Simon reported
> is in 8.3 already, so that's the only known issue left.

Hi Joel,

Sure thing.  I've just backported it and made sure that GDB builds
correctly.  I think you can go ahead and create the new pre-release now
:-).

Thanks!

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

> There is a regression that affects the release branch and causes some
> control characters to be printed infinitely when listing source files
> (see <https://sourceware.org/ml/gdb-patches/2019-03/msg00611.html>).
> This one isn't fixed.

Thanks for bringing it to our attention. This is very annoying.
Does it happen all the time, or only under specific circumstances?
In other words, I'm wondering if we have some kind of workaround.

Tom - would you be OK to put this on your list to look at, sometime?

> There is a testsuite issue that was fixed in
> <https://sourceware.org/ml/gdb-patches/2019-03/msg00142.html>
> (gdb/testsuite: Prepare for DejaGnu 1.6.2), but I haven't seen the
> corresponding commit in gdb-8.3-branch.  The commit that causes the
> issue is in the branch.  I posted a message in that thread asking if it
> makes sense to include it in the release branch.

This ones looks pretty straightforward to me, and I will send Andrew
my vote.

> There is another testsuite issue that was fixed, but the fix doesn't seem
> to be in the release branch yet
> <https://sourceware.org/ml/gdb-patches/2019-03/msg00613.html>.

This one, I think is OK, but it isn't as clear. It's not clear also
how critical it is for gdb-8.3. Pedro?

-- 
Joel

Re: GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

> Sure thing.  I've just backported it and made sure that GDB builds
> correctly.  I think you can go ahead and create the new pre-release now
> :-).

Thanks! There is still one known issue that Pedro FdC reported,
but I think I'll create a pre-release now anyway. We'll just have
to hope that the fix, when it arrives, is simple enough that
we can do without another pre-release.

-- 
Joel

Re: GDB 8.3 release update (2019-03-25)

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> There is a regression that affects the release branch and causes some
>> control characters to be printed infinitely when listing source files
>> (see <https://sourceware.org/ml/gdb-patches/2019-03/msg00611.html>).
>> This one isn't fixed.

Joel> Thanks for bringing it to our attention. This is very annoying.
Joel> Does it happen all the time, or only under specific circumstances?
Joel> In other words, I'm wondering if we have some kind of workaround.

Joel> Tom - would you be OK to put this on your list to look at, sometime?

Sure thing.  I think there's already a patch.

Tom

Re: GDB 8.3 release update (2019-03-25)

[Pedro Franco de Carvalho]

Joel Brobecker <brobecker@adacore.com> writes:

> Does it happen all the time, or only under specific circumstances?
> In other words, I'm wondering if we have some kind of workaround.

It seems to happen all the time with the CLI (it doesn't affect the
TUI).

> This ones looks pretty straightforward to me, and I will send Andrew
> my vote.

Thanks, I saw you merged this one.

--
Pedro Franco de Carvalho

Re: GDB 8.3 release update (2019-03-25)

[Pedro Alves]

On 03/26/2019 10:21 PM, Joel Brobecker wrote:
>> There is another testsuite issue that was fixed, but the fix doesn't seem
>> to be in the release branch yet
>> <https://sourceware.org/ml/gdb-patches/2019-03/msg00613.html>.
> This one, I think is OK, but it isn't as clear. It's not clear also
> how critical it is for gdb-8.3. Pedro?

It's not critical in the sense that it fixes anything regular uses
might notice.  It fixes a testsuite hang when some testcase hits a tcl
error, IOW, when a testcase has some buglet.  Pedro ran into such a hang
more than once, so it'd likely help testers if the patch was merged.
I think the patch itself is pretty low risk.  I think it'd be OK to put
it in the branch.

Thanks,
Pedro Alves

Re: GDB 8.3 release update (2019-03-25)

[Joel Brobecker]

> >> There is another testsuite issue that was fixed, but the fix doesn't seem
> >> to be in the release branch yet
> >> <https://sourceware.org/ml/gdb-patches/2019-03/msg00613.html>.
> > This one, I think is OK, but it isn't as clear. It's not clear also
> > how critical it is for gdb-8.3. Pedro?
> 
> It's not critical in the sense that it fixes anything regular uses
> might notice.  It fixes a testsuite hang when some testcase hits a tcl
> error, IOW, when a testcase has some buglet.  Pedro ran into such a hang
> more than once, so it'd likely help testers if the patch was merged.
> I think the patch itself is pretty low risk.  I think it'd be OK to put
> it in the branch.

Thanks for confirming, Pedro. This one is now in gdb-8.3-branch as well.

-- 
Joel