[PATCH] Remove dead code from gdbserver's configure

[PATCH] Remove dead code from gdbserver's configure

[Tom Tromey]

gdbserver's configure removes -Wmissing-prototypes from the warning
flags.  However, this flag is only useful for C, so this deletion is
no longer needed.

gdb/gdbserver/ChangeLog
2018-09-24  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* configure.ac (WARN_CFLAGS): Don't remove -Wmissing-prototypes.
---
 gdb/gdbserver/ChangeLog    | 5 +++++
 gdb/gdbserver/configure    | 5 -----
 gdb/gdbserver/configure.ac | 6 ------
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index f5cbbaea78..43846659fb 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -7391,11 +7391,6 @@ ac_link='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $
 ac_compiler_gnu=$ac_cv_c_compiler_gnu
 
 
-case " $WARN_CFLAGS " in
-*" -Wmissing-prototypes "*)
-  WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes"
-  ;;
-esac
 
 old_LIBS="$LIBS"
 LIBS="$LIBS -ldl"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 99bc46221c..fa3ca53efd 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -157,12 +157,6 @@ AC_SUBST(ustlibs)
 AC_SUBST(ustinc)
 
 AM_GDB_WARNINGS
-dnl The codebase isn't clean yet with this flag.
-case " $WARN_CFLAGS " in
-*" -Wmissing-prototypes "*)
-  WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes"
-  ;;
-esac
 
 dnl dladdr is glibc-specific.  It is used by thread-db.c but only for
 dnl debugging messages.  It lives in -ldl which is handled below so we don't
-- 
2.17.1

Re: [PATCH] Remove dead code from gdbserver's configure

[Simon Marchi]

On 2018-09-24 06:21 PM, Tom Tromey wrote:
> gdbserver's configure removes -Wmissing-prototypes from the warning
> flags.  However, this flag is only useful for C, so this deletion is
> no longer needed.

It indeed doesn't look useful anymore.

Simon