From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] Remove dead code from gdbserver's configure
Date: Mon, 24 Sep 2018 22:21:00 -0000 [thread overview]
Message-ID: <20180924222129.29300-1-tom@tromey.com> (raw)
gdbserver's configure removes -Wmissing-prototypes from the warning
flags. However, this flag is only useful for C, so this deletion is
no longer needed.
gdb/gdbserver/ChangeLog
2018-09-24 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac (WARN_CFLAGS): Don't remove -Wmissing-prototypes.
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/configure | 5 -----
gdb/gdbserver/configure.ac | 6 ------
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index f5cbbaea78..43846659fb 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -7391,11 +7391,6 @@ ac_link='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $
ac_compiler_gnu=$ac_cv_c_compiler_gnu
-case " $WARN_CFLAGS " in
-*" -Wmissing-prototypes "*)
- WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes"
- ;;
-esac
old_LIBS="$LIBS"
LIBS="$LIBS -ldl"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 99bc46221c..fa3ca53efd 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -157,12 +157,6 @@ AC_SUBST(ustlibs)
AC_SUBST(ustinc)
AM_GDB_WARNINGS
-dnl The codebase isn't clean yet with this flag.
-case " $WARN_CFLAGS " in
-*" -Wmissing-prototypes "*)
- WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes"
- ;;
-esac
dnl dladdr is glibc-specific. It is used by thread-db.c but only for
dnl debugging messages. It lives in -ldl which is handled below so we don't
--
2.17.1
next reply other threads:[~2018-09-24 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 22:21 Tom Tromey [this message]
2018-09-25 3:31 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924222129.29300-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox