Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Make read_program_headers_from_bfd return a gdb::byte_vector
Date: Wed, 22 Aug 2018 17:53:00 -0000	[thread overview]
Message-ID: <20180822105309.35107db4@pinnacle.lan> (raw)
In-Reply-To: <20180820012947.10928-2-simon.marchi@polymtl.ca>

On Sun, 19 Aug 2018 21:29:47 -0400
Simon Marchi <simon.marchi@polymtl.ca> wrote:

> This patch makes read_program_headers_from_bfd return a gdb::byte_vector
> instead of a plain pointer.
> 
> gdb/ChangeLog:
> 
> 	* solib-svr4.c (read_program_headers_from_bfd): Return
> 	gdb::optional<gdb::byte_vector>.
> 	(svr4_exec_displacement): Adjust.

LGTM.

Kevin


  reply	other threads:[~2018-08-22 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  1:30 [PATCH 1/2] Make read_program_header " Simon Marchi
2018-08-20  1:30 ` [PATCH 2/2] Make read_program_headers_from_bfd " Simon Marchi
2018-08-22 17:53   ` Kevin Buettner [this message]
2018-08-22 17:45 ` [PATCH 1/2] Make read_program_header " Kevin Buettner
2018-08-22 18:19   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822105309.35107db4@pinnacle.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox