From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93769 invoked by alias); 22 Aug 2018 17:53:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93754 invoked by uid 89); 22 Aug 2018 17:53:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Aug 2018 17:53:11 +0000 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8072B30E6841 for ; Wed, 22 Aug 2018 17:53:10 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-27.phx2.redhat.com [10.3.116.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5BA82309132E for ; Wed, 22 Aug 2018 17:53:10 +0000 (UTC) Date: Wed, 22 Aug 2018 17:53:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Make read_program_headers_from_bfd return a gdb::byte_vector Message-ID: <20180822105309.35107db4@pinnacle.lan> In-Reply-To: <20180820012947.10928-2-simon.marchi@polymtl.ca> References: <20180820012947.10928-1-simon.marchi@polymtl.ca> <20180820012947.10928-2-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00553.txt.bz2 On Sun, 19 Aug 2018 21:29:47 -0400 Simon Marchi wrote: > This patch makes read_program_headers_from_bfd return a gdb::byte_vector > instead of a plain pointer. > > gdb/ChangeLog: > > * solib-svr4.c (read_program_headers_from_bfd): Return > gdb::optional. > (svr4_exec_displacement): Adjust. LGTM. Kevin