Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Make read_program_header return a gdb::byte_vector
Date: Wed, 22 Aug 2018 18:19:00 -0000	[thread overview]
Message-ID: <aa4ca6f51f57d949e66c314430373740@polymtl.ca> (raw)
In-Reply-To: <20180822104534.17865bb5@pinnacle.lan>

On 2018-08-22 13:45, Kevin Buettner wrote:
> On Sun, 19 Aug 2018 21:29:46 -0400
> Simon Marchi <simon.marchi@polymtl.ca> wrote:
> 
>> +   optional on failure.  If successful and P_ATCH_SIZE is non-NULL, 
>> the target
> 
> I noticed this typo: P_ATCH_SIZE should be P_ARCH_SIZE.
> 
> Otherwise, LGTM.

Thanks, I pushed the series with that fixed.

Simon


      reply	other threads:[~2018-08-22 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  1:30 Simon Marchi
2018-08-20  1:30 ` [PATCH 2/2] Make read_program_headers_from_bfd " Simon Marchi
2018-08-22 17:53   ` Kevin Buettner
2018-08-22 17:45 ` [PATCH 1/2] Make read_program_header " Kevin Buettner
2018-08-22 18:19   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa4ca6f51f57d949e66c314430373740@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox