Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH][gdb/testsuite] Fix regexp in py-rbreak.exp
@ 2018-08-03 17:51 Tom de Vries
  2018-08-03 18:45 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2018-08-03 17:51 UTC (permalink / raw)
  To: gdb-patches

Hi,

this fails for me on openSUSE Leap 15.0:
...
FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
...

The rbreak "" command expects 11 breaks, but I see two extra for
__libc_csu_fini and __libc_csu_init:
...
Breakpoint 13 at 0x4005b0: file elf-init.c, line 106.^M
Breakpoint 14 at 0x400540: file elf-init.c, line 68.^M
...

This patch fixes the failing test by excluding functions starting with an
underscore.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Fix regexp in py-rbreak.exp

---
 gdb/testsuite/gdb.python/py-rbreak.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp
index 97ebd79f67..8e68402179 100644
--- a/gdb/testsuite/gdb.python/py-rbreak.exp
+++ b/gdb/testsuite/gdb.python/py-rbreak.exp
@@ -33,7 +33,7 @@ if ![runto_main] then {
 }
 
 gdb_test_no_output "nosharedlibrary"
-gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \
+gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"^\[^_\]\",minsyms=False)" \
     "get all function breakpoints" 0
 gdb_test "py print(len(sl))" "11" \
     "check number of returned breakpoints is 11"

OK for trunk?


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][gdb/testsuite] Fix regexp in py-rbreak.exp
  2018-08-03 17:51 [PATCH][gdb/testsuite] Fix regexp in py-rbreak.exp Tom de Vries
@ 2018-08-03 18:45 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2018-08-03 18:45 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> This patch fixes the failing test by excluding functions starting with an
Tom> underscore.

Tom> Tested on x86_64-linux.

Tom> OK for trunk?

Yes, this is ok.  Thanks.

Tom


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-03 18:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 17:51 [PATCH][gdb/testsuite] Fix regexp in py-rbreak.exp Tom de Vries
2018-08-03 18:45 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox