From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4958 invoked by alias); 3 Aug 2018 17:51:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4948 invoked by uid 89); 3 Aug 2018 17:51:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=rbreak, leap X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Aug 2018 17:51:38 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9E309AD4A for ; Fri, 3 Aug 2018 17:51:36 +0000 (UTC) Date: Fri, 03 Aug 2018 17:51:00 -0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Fix regexp in py-rbreak.exp Message-ID: <20180803175159.ygcc5r7jwtt6zqqz@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170912 (1.9.0) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00065.txt.bz2 Hi, this fails for me on openSUSE Leap 15.0: ... FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11 ... The rbreak "" command expects 11 breaks, but I see two extra for __libc_csu_fini and __libc_csu_init: ... Breakpoint 13 at 0x4005b0: file elf-init.c, line 106.^M Breakpoint 14 at 0x400540: file elf-init.c, line 68.^M ... This patch fixes the failing test by excluding functions starting with an underscore. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Fix regexp in py-rbreak.exp --- gdb/testsuite/gdb.python/py-rbreak.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp index 97ebd79f67..8e68402179 100644 --- a/gdb/testsuite/gdb.python/py-rbreak.exp +++ b/gdb/testsuite/gdb.python/py-rbreak.exp @@ -33,7 +33,7 @@ if ![runto_main] then { } gdb_test_no_output "nosharedlibrary" -gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \ +gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"^\[^_\]\",minsyms=False)" \ "get all function breakpoints" 0 gdb_test "py print(len(sl))" "11" \ "check number of returned breakpoints is 11" OK for trunk?