Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Nick Clifton <nickc@redhat.com>,
	gdb-patches@sourceware.org,	binutils@sourceware.org,
	Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH 1/2] Bump to autoconf 2.69 and automake 1.15.1
Date: Mon, 18 Jun 2018 02:46:00 -0000	[thread overview]
Message-ID: <20180618024632.GZ7660@bubble.grove.modra.org> (raw)
In-Reply-To: <8b17a501-41ca-4a7e-ba4d-bc498eb27d85@polymtl.ca>

On Fri, Jun 15, 2018 at 11:55:40PM -0400, Simon Marchi wrote:
> On 2018-06-15 09:39 PM, Alan Modra wrote:
> > On Fri, Jun 15, 2018 at 03:22:10PM +0100, Nick Clifton wrote:
> >> Otherwise so far, my testing has been showing no signs of any real problems.
> > 
> > The patch looks good to me too.  I did see some generated file
> > differences, most of which disappeared when I compiled my own
> > autoconf-2.69 rather than using the Ubuntu 18.04 version (which
> > apparently has some patches from autoconf-2.70 applied).
> > 
> > I applied both of your posted patches, ran autoconf in zlib since
> > you'd said the posted patch was broken, touched all the files in the
> > first patch, then built binutils-gdb with --enable-maintainer-mode.
> > Apart from .pot files, these were the files that differed:
> > 
> > bfd/doc/Makefile.in
> > binutils/doc/Makefile.in
> > gas/doc/Makefile.in
> > gdb/aclocal.m4
> > gdb/config.in
> > gdb/configure
> > gdb/gnulib/aclocal.m4
> > gdb/gnulib/configure
> > libdecnumber/aclocal.m4
> > zlib/configure
> 
> 
> 1. About aclocal.m4's, there are a bunch more generated from other versions of
> automake than 1.15.1:
[snip]

> Should I make sure to re-generate all of them?

Yes, I think that should be done whenever updating the version of
autotools.

I also just noticed these 1.11 version specifiers that probably should
be updated to 1.15:
./bfd/Makefile.am:AUTOMAKE_OPTIONS = 1.11 no-dist foreign
./gas/Makefile.am:AUTOMAKE_OPTIONS = 1.11 dejagnu foreign no-dist subdir-objects
./gprof/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist no-texinfo.tex info-in-builddir
./opcodes/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist


> 2. How do I update those */doc/Makefile.in?

Andreas has already given the canonical answer, but something like the
following should work too.

cd ~/src/binutils-gdb/bfd && automake-1.15 --foreign doc/Makefile
cd ~/src/binutils-gdb/binutils && automake-1.15 --foreign doc/Makefile
cd ~/src/binutils-gdb/gas && automake-1.15 --foreign doc/Makefile

-- 
Alan Modra
Australia Development Lab, IBM


  parent reply	other threads:[~2018-06-18  2:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15  0:43 Simon Marchi
2018-06-15  0:46 ` [PATCH 2/2] Generated files Simon Marchi
2018-06-15  3:00   ` Simon Marchi
2018-06-15 14:22 ` [PATCH 1/2] Bump to autoconf 2.69 and automake 1.15.1 Nick Clifton
2018-06-15 14:38   ` Simon Marchi
2018-06-15 14:58     ` Nick Clifton
2018-06-15 15:14       ` Simon Marchi
2018-06-15 15:30         ` Nick Clifton
2018-06-15 15:38           ` Simon Marchi
2018-06-15 15:54             ` Nick Clifton
2018-06-16  1:39   ` Alan Modra
2018-06-16  3:56     ` Simon Marchi
2018-06-16  7:17       ` Andreas Schwab
2018-06-18  2:46       ` Alan Modra [this message]
2018-06-18  3:05         ` Simon Marchi
2018-06-18  9:42           ` Nick Clifton
2018-06-15 17:29 ` Joseph Myers
2018-06-16  3:05   ` Simon Marchi
2018-06-18 15:12     ` Joseph Myers
2018-06-18 15:32       ` Simon Marchi
2018-06-16 22:41 ` Andreas K. Huettel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180618024632.GZ7660@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=simon.marchi@ericsson.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox