From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117237 invoked by alias); 18 Jun 2018 02:46:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117207 invoked by uid 89); 18 Jun 2018 02:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:209.85.192.193, Hx-spam-relays-external:209.85.192.193, foreign X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Jun 2018 02:46:39 +0000 Received: by mail-pf0-f193.google.com with SMTP id q1-v6so7409181pff.13; Sun, 17 Jun 2018 19:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HLA08vm+VLazD//c9ULmUq8a6+MMgMZ7YpdnSzRepKQ=; b=phLMl24MYob9jF/403kS7KTd4Jk86wY1++fXBd3m/A/in0sRS7IfvRW6oIXwfL78sl xuqE7t6JZcpWsocHimPf35dWldgAZEIDVpu9Pf43cUU8JRpueQbSN+Wrd+/j7uf3cSbG I3Xx+mGCy0pF+VXtivHYLe2mzydexhcvSOBog/TLygQkWzcr+QjK6tB2+P+r0zBcDZB3 cK/8Mkj+UW4A2LpPD4OqQBFZcR2O5NbPA0s+v5y1rEsMGBwEm+KQ03YWXcpJp/daNfe+ rvM0llOsZiS2+kF4mXmYXpBvIDEmllZ3/Tp2CioHNF51ODLLX7mJl5L3aTMwv3d00RBc EVkQ== X-Gm-Message-State: APt69E3rid4WTqcbHzX8B1vvEQ7O/elvHawIQnuoH373jjjP8IzCgivS yuD1SPSEmQdiem013vTgUSs= X-Google-Smtp-Source: ADUXVKKdza5xck2X1rX8kivjAHjGhHWVgXySJCqMqfAckY7a+Cq030+WbT/dUh46hseFxgeeDinz8w== X-Received: by 2002:a63:3115:: with SMTP id x21-v6mr9353755pgx.373.1529289998250; Sun, 17 Jun 2018 19:46:38 -0700 (PDT) Received: from bubble.grove.modra.org ([58.175.241.133]) by smtp.gmail.com with ESMTPSA id j3-v6sm16447903pgp.47.2018.06.17.19.46.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Jun 2018 19:46:37 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2E21080D60; Mon, 18 Jun 2018 12:16:33 +0930 (ACST) Date: Mon, 18 Jun 2018 02:46:00 -0000 From: Alan Modra To: Simon Marchi Cc: Nick Clifton , gdb-patches@sourceware.org, binutils@sourceware.org, Simon Marchi Subject: Re: [PATCH 1/2] Bump to autoconf 2.69 and automake 1.15.1 Message-ID: <20180618024632.GZ7660@bubble.grove.modra.org> References: <20180615004309.29913-1-simon.marchi@polymtl.ca> <20180616013916.GW7660@bubble.grove.modra.org> <8b17a501-41ca-4a7e-ba4d-bc498eb27d85@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b17a501-41ca-4a7e-ba4d-bc498eb27d85@polymtl.ca> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00433.txt.bz2 On Fri, Jun 15, 2018 at 11:55:40PM -0400, Simon Marchi wrote: > On 2018-06-15 09:39 PM, Alan Modra wrote: > > On Fri, Jun 15, 2018 at 03:22:10PM +0100, Nick Clifton wrote: > >> Otherwise so far, my testing has been showing no signs of any real problems. > > > > The patch looks good to me too. I did see some generated file > > differences, most of which disappeared when I compiled my own > > autoconf-2.69 rather than using the Ubuntu 18.04 version (which > > apparently has some patches from autoconf-2.70 applied). > > > > I applied both of your posted patches, ran autoconf in zlib since > > you'd said the posted patch was broken, touched all the files in the > > first patch, then built binutils-gdb with --enable-maintainer-mode. > > Apart from .pot files, these were the files that differed: > > > > bfd/doc/Makefile.in > > binutils/doc/Makefile.in > > gas/doc/Makefile.in > > gdb/aclocal.m4 > > gdb/config.in > > gdb/configure > > gdb/gnulib/aclocal.m4 > > gdb/gnulib/configure > > libdecnumber/aclocal.m4 > > zlib/configure > > > 1. About aclocal.m4's, there are a bunch more generated from other versions of > automake than 1.15.1: [snip] > Should I make sure to re-generate all of them? Yes, I think that should be done whenever updating the version of autotools. I also just noticed these 1.11 version specifiers that probably should be updated to 1.15: ./bfd/Makefile.am:AUTOMAKE_OPTIONS = 1.11 no-dist foreign ./gas/Makefile.am:AUTOMAKE_OPTIONS = 1.11 dejagnu foreign no-dist subdir-objects ./gprof/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist no-texinfo.tex info-in-builddir ./opcodes/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist > 2. How do I update those */doc/Makefile.in? Andreas has already given the canonical answer, but something like the following should work too. cd ~/src/binutils-gdb/bfd && automake-1.15 --foreign doc/Makefile cd ~/src/binutils-gdb/binutils && automake-1.15 --foreign doc/Makefile cd ~/src/binutils-gdb/gas && automake-1.15 --foreign doc/Makefile -- Alan Modra Australia Development Lab, IBM