From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: prudo@linux.vnet.ibm.com (Philipp Rudo)
Cc: gdb-patches@sourceware.org,
arnez@linux.vnet.ibm.com (Andreas Arnez),
qiyaoltc@gmail.com (Yao Qi)
Subject: Re: [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism
Date: Thu, 14 Dec 2017 15:45:00 -0000 [thread overview]
Message-ID: <20171214154431.80F64D85C61@oc3748833570.ibm.com> (raw)
In-Reply-To: <20171214130847.74f85259@ThinkPad> from "Philipp Rudo" at Dec 14, 2017 01:08:47 PM
Philipp Rudo wrote:
> ... I moved init_osabi so early so only the functions which are overwritten by
> the osabi (or needed for other reasons like the dwarf unwinder) are set before
> it. I hoped this would make the gdbarch_init clearer as the list before
> init_osabi is shorter and you can say for sure that all hooks set after are
> shared between all OSes. So you are not surprised with some special cases you
> don't expect. Of course this also means that if you want to overwrite a
> function you first have to move it before osabi_init. For me that is a small
> price to pay.
>
> However when you prefer the osabi_init to be done later I can move it to where
> linux_init_abi is called today. In that case i can avoid moving
> dwarf2_append_unwinders. Otherwise I will move the other
> dwarf2 related routines up. Just tell me what you prefer.
Yes, please do move init_osabi to be done later.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2017-12-14 15:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 11:04 [PATCH v3 00/10] Split up s390-linux-tdep.c Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 08/10] s390: gdbarch_tdep add hook for syscall record Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 05/10] s390: Move tdesc validation to separate function Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 03/10] s390: gdbarch_tdep.have_* int -> bool Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 01/10] s390: Remove duplicate checks for cached gdbarch at init Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism Philipp Rudo
2017-12-13 18:42 ` Ulrich Weigand
2017-12-14 12:08 ` Philipp Rudo
2017-12-14 15:45 ` Ulrich Weigand [this message]
2017-12-15 16:19 ` Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 06/10] s390: if -> gdb_assert for tdesc_has_registers check Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 04/10] s390: gdbarch_tdep add field tdesc Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 02/10] s390: Allocate gdbarch & tdep at start of gdbarch init Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 10/10] s390: Clean up s390-linux-tdep.c Philipp Rudo
2017-12-08 11:56 ` [PATCH v3 09/10] s390: Split up s390-linux-tdep.c into two files Philipp Rudo
2017-12-08 11:56 ` [PATCH v3 09/10 b] " Philipp Rudo
2017-12-08 11:56 ` [PATCH v3 09/10 a] " Philipp Rudo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214154431.80F64D85C61@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=prudo@linux.vnet.ibm.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox