From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60871 invoked by alias); 14 Dec 2017 15:45:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58161 invoked by uid 89); 14 Dec 2017 15:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=price, pay X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 15:45:21 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBEFjA5Y130123 for ; Thu, 14 Dec 2017 10:45:20 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2eus248rkm-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 14 Dec 2017 10:45:14 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Dec 2017 15:44:34 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 14 Dec 2017 15:44:32 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vBEFiVCf62717966; Thu, 14 Dec 2017 15:44:31 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2565C4C04A; Thu, 14 Dec 2017 15:39:15 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1407F4C046; Thu, 14 Dec 2017 15:39:15 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.29]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 14 Dec 2017 15:39:15 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 80F64D85C61; Thu, 14 Dec 2017 16:44:31 +0100 (CET) Subject: Re: [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism To: prudo@linux.vnet.ibm.com (Philipp Rudo) Date: Thu, 14 Dec 2017 15:45:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, arnez@linux.vnet.ibm.com (Andreas Arnez), qiyaoltc@gmail.com (Yao Qi) In-Reply-To: <20171214130847.74f85259@ThinkPad> from "Philipp Rudo" at Dec 14, 2017 01:08:47 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121415-0040-0000-0000-000003FA2817 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121415-0041-0000-0000-000025FD3C8B Message-Id: <20171214154431.80F64D85C61@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-14_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712140216 X-SW-Source: 2017-12/txt/msg00349.txt.bz2 Philipp Rudo wrote: > ... I moved init_osabi so early so only the functions which are overwritten by > the osabi (or needed for other reasons like the dwarf unwinder) are set before > it. I hoped this would make the gdbarch_init clearer as the list before > init_osabi is shorter and you can say for sure that all hooks set after are > shared between all OSes. So you are not surprised with some special cases you > don't expect. Of course this also means that if you want to overwrite a > function you first have to move it before osabi_init. For me that is a small > price to pay. > > However when you prefer the osabi_init to be done later I can move it to where > linux_init_abi is called today. In that case i can avoid moving > dwarf2_append_unwinders. Otherwise I will move the other > dwarf2 related routines up. Just tell me what you prefer. Yes, please do move init_osabi to be done later. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com