Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
	       Ulrich Weigand <uweigand@de.ibm.com>,
	Yao Qi <qiyaoltc@gmail.com>
Subject: [PATCH v3 03/10] s390: gdbarch_tdep.have_* int -> bool
Date: Fri, 08 Dec 2017 11:04:00 -0000	[thread overview]
Message-ID: <20171208110436.30199-4-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171208110436.30199-1-prudo@linux.vnet.ibm.com>

Currently the gdbarch_tdep.have_* flags are a mix of int and bool.  Clean
this up by making them all bool.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
	<have_tdb>: Change type to bool.
	(s390_gdbarch_tdep_alloc): Adjust.
	(s390_gdbarch_init): Adjust.
---
 gdb/s390-linux-tdep.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
index 0b54365c9d..03146289df 100644
--- a/gdb/s390-linux-tdep.c
+++ b/gdb/s390-linux-tdep.c
@@ -113,9 +113,9 @@ struct gdbarch_tdep
   int v0_full_regnum;
 
   bool have_upper;
-  int have_linux_v1;
-  int have_linux_v2;
-  int have_tdb;
+  bool have_linux_v1;
+  bool have_linux_v2;
+  bool have_tdb;
   bool have_vx;
   bool have_gs;
 };
@@ -7825,9 +7825,9 @@ s390_gdbarch_tdep_alloc ()
   tdep->cc_regnum = -1;
 
   tdep->have_upper = false;
-  tdep->have_linux_v1 = 0;
-  tdep->have_linux_v2 = 0;
-  tdep->have_tdb = 0;
+  tdep->have_linux_v1 = false;
+  tdep->have_linux_v2 = false;
+  tdep->have_tdb = false;
   tdep->have_vx = false;
   tdep->have_gs = false;
 
@@ -7995,13 +7995,13 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
 	  if (tdesc_numbered_register (feature, tdesc_data,
 				       S390_LAST_BREAK_REGNUM, "last_break"))
-	    tdep->have_linux_v1 = 1;
+	    tdep->have_linux_v1 = true;
 
 	  if (tdesc_numbered_register (feature, tdesc_data,
 				       S390_SYSTEM_CALL_REGNUM, "system_call"))
-	    tdep->have_linux_v2 = 1;
+	    tdep->have_linux_v2 = true;
 
-	  if (tdep->have_linux_v2 > tdep->have_linux_v1)
+	  if (tdep->have_linux_v2 && !tdep->have_linux_v1)
 	    valid_p = 0;
 	}
 
@@ -8013,7 +8013,7 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 	    valid_p &= tdesc_numbered_register (feature, tdesc_data,
 						S390_TDB_DWORD0_REGNUM + i,
 						tdb_regs[i]);
-	  tdep->have_tdb = 1;
+	  tdep->have_tdb = true;
 	}
 
       /* Vector registers.  */
-- 
2.13.5


  parent reply	other threads:[~2017-12-08 11:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 11:04 [PATCH v3 00/10] Split up s390-linux-tdep.c Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 08/10] s390: gdbarch_tdep add hook for syscall record Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 05/10] s390: Move tdesc validation to separate function Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism Philipp Rudo
2017-12-13 18:42   ` Ulrich Weigand
2017-12-14 12:08     ` Philipp Rudo
2017-12-14 15:45       ` Ulrich Weigand
2017-12-15 16:19         ` Philipp Rudo
2017-12-08 11:04 ` [PATCH v3 01/10] s390: Remove duplicate checks for cached gdbarch at init Philipp Rudo
2017-12-08 11:04 ` Philipp Rudo [this message]
2017-12-08 11:05 ` [PATCH v3 10/10] s390: Clean up s390-linux-tdep.c Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 02/10] s390: Allocate gdbarch & tdep at start of gdbarch init Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 04/10] s390: gdbarch_tdep add field tdesc Philipp Rudo
2017-12-08 11:05 ` [PATCH v3 06/10] s390: if -> gdb_assert for tdesc_has_registers check Philipp Rudo
2017-12-08 11:56 ` [PATCH v3 09/10] s390: Split up s390-linux-tdep.c into two files Philipp Rudo
2017-12-08 11:56   ` [PATCH v3 09/10 b] " Philipp Rudo
2017-12-08 11:56   ` [PATCH v3 09/10 a] " Philipp Rudo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208110436.30199-4-prudo@linux.vnet.ibm.com \
    --to=prudo@linux.vnet.ibm.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox