Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* New ARI warning Wed Dec 13 01:56:09 UTC 2017
@ 2017-12-13  1:56 GDB Administrator
  2017-12-13  2:53 ` Simon Marchi
  0 siblings, 1 reply; 3+ messages in thread
From: GDB Administrator @ 2017-12-13  1:56 UTC (permalink / raw)
  To: gdb-patches

394a395,403
> gdb/or1k-tdep.c:135: gettext: _ markup: All messages should be marked up with _.
gdb/or1k-tdep.c:135:	    error ("bitstring \"%s\" at offset %d has no length field.\n",
> gdb/or1k-tdep.c:144: gettext: _ markup: All messages should be marked up with _.
gdb/or1k-tdep.c:144:	    error ("bitstring \"%s\" at offset %d has no terminating 'b'.\n",
> gdb/or1k-tdep.c:161: gettext: _ markup: All messages should be marked up with _.
gdb/or1k-tdep.c:161:	  error ("invalid character in bitstring \"%s\" at offset %d.\n",
> gdb/or1k-tdep.c:544: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/or1k-tdep.c:544:    fprintf_unfiltered (gdb_stdlog, "or1k_unwind_pc, pc=0x%p\n",
> gdb/or1k-tdep.c:564: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/or1k-tdep.c:564:    fprintf_unfiltered (gdb_stdlog, "or1k_unwind_sp, sp=0x%p\n",
> gdb/or1k-tdep.c:885: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/or1k-tdep.c:885:			"or1k_frame_cache, prologue_cache = 0x%p\n",
> gdb/or1k-tdep.c:945: gettext: _ markup: All messages should be marked up with _.
gdb/or1k-tdep.c:945:    error ("end addr 0x%08x is less than start addr 0x%08x\n",
> gdb/or1k-tdep.c:1071: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/or1k-tdep.c:1071:      fprintf_unfiltered (gdb_stdlog, "  this_sp_for_id = 0x%p\n",
> gdb/or1k-tdep.c:1073: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/or1k-tdep.c:1073:      fprintf_unfiltered (gdb_stdlog, "  start_addr     = 0x%p\n",


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New ARI warning Wed Dec 13 01:56:09 UTC 2017
  2017-12-13  1:56 New ARI warning Wed Dec 13 01:56:09 UTC 2017 GDB Administrator
@ 2017-12-13  2:53 ` Simon Marchi
  2017-12-13  3:02   ` Stafford Horne
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2017-12-13  2:53 UTC (permalink / raw)
  To: shorne; +Cc: gdb-patches

On 2017-12-12 20:56, GDB Administrator wrote:
> 394a395,403
>> gdb/or1k-tdep.c:135: gettext: _ markup: All messages should be marked 
>> up with _.
> gdb/or1k-tdep.c:135:	    error ("bitstring \"%s\" at offset %d has no
> length field.\n",
>> gdb/or1k-tdep.c:144: gettext: _ markup: All messages should be marked 
>> up with _.
> gdb/or1k-tdep.c:144:	    error ("bitstring \"%s\" at offset %d has no
> terminating 'b'.\n",
>> gdb/or1k-tdep.c:161: gettext: _ markup: All messages should be marked 
>> up with _.
> gdb/or1k-tdep.c:161:	  error ("invalid character in bitstring \"%s\"
> at offset %d.\n",
>> gdb/or1k-tdep.c:544: code: %p: Do not use printf(%p), instead use 
>> printf(%s,paddr()) to dump a target address, or 
>> host_address_to_string() for a host address
> gdb/or1k-tdep.c:544:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_pc, pc=0x%p\n",
>> gdb/or1k-tdep.c:564: code: %p: Do not use printf(%p), instead use 
>> printf(%s,paddr()) to dump a target address, or 
>> host_address_to_string() for a host address
> gdb/or1k-tdep.c:564:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_sp, sp=0x%p\n",
>> gdb/or1k-tdep.c:885: code: %p: Do not use printf(%p), instead use 
>> printf(%s,paddr()) to dump a target address, or 
>> host_address_to_string() for a host address
> gdb/or1k-tdep.c:885:			"or1k_frame_cache, prologue_cache = 0x%p\n",
>> gdb/or1k-tdep.c:945: gettext: _ markup: All messages should be marked 
>> up with _.
> gdb/or1k-tdep.c:945:    error ("end addr 0x%08x is less than start
> addr 0x%08x\n",
>> gdb/or1k-tdep.c:1071: code: %p: Do not use printf(%p), instead use 
>> printf(%s,paddr()) to dump a target address, or 
>> host_address_to_string() for a host address
> gdb/or1k-tdep.c:1071:      fprintf_unfiltered (gdb_stdlog, "
> this_sp_for_id = 0x%p\n",
>> gdb/or1k-tdep.c:1073: code: %p: Do not use printf(%p), instead use 
>> printf(%s,paddr()) to dump a target address, or 
>> host_address_to_string() for a host address
> gdb/or1k-tdep.c:1073:      fprintf_unfiltered (gdb_stdlog, "
> start_addr     = 0x%p\n",

Hi Stafford,

Could you address the warnings mentioned above?  They should be pretty 
straightforward, I think it will be an obvious patch.

Simon


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New ARI warning Wed Dec 13 01:56:09 UTC 2017
  2017-12-13  2:53 ` Simon Marchi
@ 2017-12-13  3:02   ` Stafford Horne
  0 siblings, 0 replies; 3+ messages in thread
From: Stafford Horne @ 2017-12-13  3:02 UTC (permalink / raw)
  To: Simon Marchi; +Cc: GDB patches

On 13 Dec 2017 11:53 a.m., "Simon Marchi" <simon.marchi@polymtl.ca> wrote:

On 2017-12-12 20:56, GDB Administrator wrote:

> 394a395,403
>
>> gdb/or1k-tdep.c:135: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:135:        error ("bitstring \"%s\" at offset %d has no
> length field.\n",
>
>> gdb/or1k-tdep.c:144: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:144:        error ("bitstring \"%s\" at offset %d has no
> terminating 'b'.\n",
>
>> gdb/or1k-tdep.c:161: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:161:      error ("invalid character in bitstring \"%s\"
> at offset %d.\n",
>
>> gdb/or1k-tdep.c:544: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:544:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_pc, pc=0x%p\n",
>
>> gdb/or1k-tdep.c:564: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:564:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_sp, sp=0x%p\n",
>
>> gdb/or1k-tdep.c:885: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:885:                    "or1k_frame_cache, prologue_cache
> = 0x%p\n",
>
>> gdb/or1k-tdep.c:945: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:945:    error ("end addr 0x%08x is less than start
> addr 0x%08x\n",
>
>> gdb/or1k-tdep.c:1071: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:1071:      fprintf_unfiltered (gdb_stdlog, "
> this_sp_for_id = 0x%p\n",
>
>> gdb/or1k-tdep.c:1073: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:1073:      fprintf_unfiltered (gdb_stdlog, "
> start_addr     = 0x%p\n",
>

Hi Stafford,

Could you address the warnings mentioned above?  They should be pretty
straightforward, I think it will be an obvious patch.

Simon


Hi Simon,

Yes I just saw this. I'm out until the end of the day. I should be able to
have patches ready after I get home.

(Also replying on my phone so the multipart message might not make it to
the list.)

- Stafford


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-13  3:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-13  1:56 New ARI warning Wed Dec 13 01:56:09 UTC 2017 GDB Administrator
2017-12-13  2:53 ` Simon Marchi
2017-12-13  3:02   ` Stafford Horne

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox