Re: New ARI warning Wed Dec 13 01:56:09 UTC 2017

[Stafford Horne <shorne@gmail.com>]

On 13 Dec 2017 11:53 a.m., "Simon Marchi" <simon.marchi@polymtl.ca> wrote:

On 2017-12-12 20:56, GDB Administrator wrote:

> 394a395,403
>
>> gdb/or1k-tdep.c:135: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:135:        error ("bitstring \"%s\" at offset %d has no
> length field.\n",
>
>> gdb/or1k-tdep.c:144: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:144:        error ("bitstring \"%s\" at offset %d has no
> terminating 'b'.\n",
>
>> gdb/or1k-tdep.c:161: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:161:      error ("invalid character in bitstring \"%s\"
> at offset %d.\n",
>
>> gdb/or1k-tdep.c:544: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:544:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_pc, pc=0x%p\n",
>
>> gdb/or1k-tdep.c:564: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:564:    fprintf_unfiltered (gdb_stdlog,
> "or1k_unwind_sp, sp=0x%p\n",
>
>> gdb/or1k-tdep.c:885: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:885:                    "or1k_frame_cache, prologue_cache
> = 0x%p\n",
>
>> gdb/or1k-tdep.c:945: gettext: _ markup: All messages should be marked up
>> with _.
>>
> gdb/or1k-tdep.c:945:    error ("end addr 0x%08x is less than start
> addr 0x%08x\n",
>
>> gdb/or1k-tdep.c:1071: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:1071:      fprintf_unfiltered (gdb_stdlog, "
> this_sp_for_id = 0x%p\n",
>
>> gdb/or1k-tdep.c:1073: code: %p: Do not use printf(%p), instead use
>> printf(%s,paddr()) to dump a target address, or host_address_to_string()
>> for a host address
>>
> gdb/or1k-tdep.c:1073:      fprintf_unfiltered (gdb_stdlog, "
> start_addr     = 0x%p\n",
>

Hi Stafford,

Could you address the warnings mentioned above?  They should be pretty
straightforward, I think it will be an obvious patch.

Simon


Hi Simon,

Yes I just saw this. I'm out until the end of the day. I should be able to
have patches ready after I get home.

(Also replying on my phone so the multipart message might not make it to
the list.)

- Stafford