From: Yao Qi <qiyaoltc@gmail.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Simon Marchi <simark@simark.ca>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [pushed] Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
Date: Fri, 03 Nov 2017 12:33:00 -0000 [thread overview]
Message-ID: <20171103123319.GA318@1170ee0b50d5> (raw)
In-Reply-To: <20171025133524.AB565D807F1@oc3748833570.ibm.com>
On 17-10-25 15:35:24, Ulrich Weigand wrote:
> > On 2017-10-09 02:12 PM, Joel Brobecker wrote:
> > > One C++ thing I did notice but forgot to report...
> > >
> > >> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
> > >> + std::string in)
> > >
> > > Again, to be double-checked, but I think you want to pass the argument
> > > by reference in this case. Otherwise, you may end up having an overhead
> > > with might not be necessary due to the creation of a copy of the string
> > > being passed as argument here.
> > >
> >
> > Indeed, it's good practice to pass constant strings (or other objects) as
> > const references (const std::string &in).
>
> I've now pushed this patch (using the const reference as suggested).
>
Hi Ulrich,
this patch causes a regression on arm target,
PASS -> FAIL: gdb.base/bitops.exp: print value of 0.0 || 0
https://sourceware.org/ml/gdb-testers/2017-q4/msg03040.html
Do you have any clues?
--
Yao (é½å°§)
next prev parent reply other threads:[~2017-11-03 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 18:21 Ulrich Weigand
2017-10-09 16:07 ` Joel Brobecker
2017-10-09 16:59 ` Ulrich Weigand
2017-10-09 18:12 ` Joel Brobecker
2017-10-09 21:14 ` Simon Marchi
2017-10-25 13:35 ` [pushed] " Ulrich Weigand
2017-11-03 12:33 ` Yao Qi [this message]
2017-11-03 13:45 ` Ulrich Weigand
2017-11-03 15:00 ` Yao Qi
2017-11-03 15:11 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103123319.GA318@1170ee0b50d5 \
--to=qiyaoltc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox