Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
Date: Mon, 09 Oct 2017 16:07:00 -0000	[thread overview]
Message-ID: <20171009160656.vpsnyisfst5pq4f7@adacore.com> (raw)
In-Reply-To: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com>

Hi Ulrich,

> - Ada: This used to check sizeof (DOUBLEST) to determine which
>   type to use for floating-point literal.  This seems questionable
>   to being with (since DOUBLEST is quite unrelated to target formats),
>   and in any case we need to get rid of DOUBLEST.  I'm now simply
>   always using the largest type (builtin_long_double) -- if there's
>   a better way (not sure what the Ada standard defines here), this
>   can be updated.

I did a bit of archeology, and it looks like this was BMT (Before My
Time). But looking at the code, I *think* this may have been related
to the fact that we decode the value and store it in host-side format,
and it looks like the code is trying to find the best target-side type
match so as to avoid having to deal with too much precision if the host
isn't capable of it in the first place??? As you say, this might be
questionable, just trying to think the reasons behind it.

In any case, I looked at your changes, and they seem fine to me.
In fact, I welcome the simplification ;-).

-- 
Joel


  reply	other threads:[~2017-10-09 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 18:21 Ulrich Weigand
2017-10-09 16:07 ` Joel Brobecker [this message]
2017-10-09 16:59   ` Ulrich Weigand
2017-10-09 18:12 ` Joel Brobecker
2017-10-09 21:14   ` Simon Marchi
2017-10-25 13:35     ` [pushed] " Ulrich Weigand
2017-11-03 12:33       ` Yao Qi
2017-11-03 13:45         ` Ulrich Weigand
2017-11-03 15:00           ` Yao Qi
2017-11-03 15:11             ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009160656.vpsnyisfst5pq4f7@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox