From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100185 invoked by alias); 9 Oct 2017 16:07:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99708 invoked by uid 89); 9 Oct 2017 16:06:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*uweigand X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 16:06:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2FAE3562A5; Mon, 9 Oct 2017 12:06:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id s1fNK8gDAvaj; Mon, 9 Oct 2017 12:06:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 16E9F56275; Mon, 9 Oct 2017 12:06:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 90A4480372; Mon, 9 Oct 2017 12:06:56 -0400 (EDT) Date: Mon, 09 Oct 2017 16:07:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing Message-ID: <20171009160656.vpsnyisfst5pq4f7@adacore.com> References: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-10/txt/msg00216.txt.bz2 Hi Ulrich, > - Ada: This used to check sizeof (DOUBLEST) to determine which > type to use for floating-point literal. This seems questionable > to being with (since DOUBLEST is quite unrelated to target formats), > and in any case we need to get rid of DOUBLEST. I'm now simply > always using the largest type (builtin_long_double) -- if there's > a better way (not sure what the Ada standard defines here), this > can be updated. I did a bit of archeology, and it looks like this was BMT (Before My Time). But looking at the code, I *think* this may have been related to the fact that we decode the value and store it in host-side format, and it looks like the code is trying to find the best target-side type match so as to avoid having to deal with too much precision if the host isn't capable of it in the first place??? As you say, this might be questionable, just trying to think the reasons behind it. In any case, I looked at your changes, and they seem fine to me. In fact, I welcome the simplification ;-). -- Joel