From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120945 invoked by alias); 3 Nov 2017 12:33:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120851 invoked by uid 89); 3 Nov 2017 12:33:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*uweigand, H*r:sk:static., forgot, HContent-Transfer-Encoding:8bit X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 12:33:26 +0000 Received: by mail-wm0-f65.google.com with SMTP id z3so1208933wme.5 for ; Fri, 03 Nov 2017 05:33:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=UXyUrjkgETGxM1eXGyBlD4e3Y8MBTHN66KXcTryzqIE=; b=QjlP0LizKtAEjP7y1Q+o6cvXY3SfrEBLK4ApG/ahDbgbr5KAZbYghssrM7Vln23ozq SzXV10annObG0+gYMpAKqVfA/1H9VU9SPDIZm/vLm28XC/Z/TcU3SSq1clnfFrDGW64k C/457SVAzmxJspob/idiKhx2pOLwGxPWAsycN+kSz6oCHB37tXgLGzuhJELJGHcz+gI4 roVpuoKnVZhkMdhfeL4zFlw3jL/EkEGnnb3su9Lin2phOQggtyu74TS5UZTI2VwB6CpK FhYZW41UW3M6pzRDoLtHOPcRumMiHVoecR9Rxbw6pE4EVw+iOehds25+cd96IUrnCzge as5Q== X-Gm-Message-State: AMCzsaVsv+yZXw2pYbYD9XyIQO7NdsHieD0E+vFw/lPoWj9M4E681gr9 rSFsvuXLSq5kWsjARCy73Js= X-Google-Smtp-Source: ABhQp+R+7qS7N5XoNNtRxguf9OIxTE8MOUXUCb8BSF1MoMmFj5lKvX1QFF+GHuPJdzkIjkh8klR90Q== X-Received: by 10.28.71.90 with SMTP id u87mr4108307wma.91.1509712404093; Fri, 03 Nov 2017 05:33:24 -0700 (PDT) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id l96sm7376636wrc.21.2017.11.03.05.33.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 05:33:23 -0700 (PDT) Date: Fri, 03 Nov 2017 12:33:00 -0000 From: Yao Qi To: Ulrich Weigand Cc: Simon Marchi , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [pushed] Re: [RFC][08/19] Target FP: Use target format throughout expression parsing Message-ID: <20171103123319.GA318@1170ee0b50d5> References: <20171025133524.AB565D807F1@oc3748833570.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171025133524.AB565D807F1@oc3748833570.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00072.txt.bz2 On 17-10-25 15:35:24, Ulrich Weigand wrote: > > On 2017-10-09 02:12 PM, Joel Brobecker wrote: > > > One C++ thing I did notice but forgot to report... > > > > > >> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out, > > >> + std::string in) > > > > > > Again, to be double-checked, but I think you want to pass the argument > > > by reference in this case. Otherwise, you may end up having an overhead > > > with might not be necessary due to the creation of a copy of the string > > > being passed as argument here. > > > > > > > Indeed, it's good practice to pass constant strings (or other objects) as > > const references (const std::string &in). > > I've now pushed this patch (using the const reference as suggested). > Hi Ulrich, this patch causes a regression on arm target, PASS -> FAIL: gdb.base/bitops.exp: print value of 0.0 || 0 https://sourceware.org/ml/gdb-testers/2017-q4/msg03040.html Do you have any clues? -- Yao (齐尧)