Re: [PATCH 4/6] Disassembly unit test: disassemble one instruction

[Yao Qi <qiyaoltc@gmail.com>]

On 17-01-20 00:03:48, Pedro Alves wrote:
> > +  /* Test gdb_disassembler for a given gdbarch by reading data from a
> > +     pre-allocated buffer.  If you want to see the disassembled
> > +     instruction printed to gdb_stdout, set DISASSEMBLER_TEST_VERBOSE
> > +     to true.  */
> > +
> > +  class gdb_disassembler_test : public gdb_disassembler
> > +  {
> > +  public:
> > +
> > +    const bool DISASSEMBLER_TEST_VERBOSE = false;
> 
> static.  We give macros long unique names in order to
> avoid naming conflicts, but if this is no longer a macro,
> the name could be shortened, to e.g., just:
> 
>  static const bool verbose = false;
> 

gdb_disassembler_test is a local class, so it can't have a static data
member.

I'll update patch to address your other comments.

-- 
Yao (齐尧)