From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129611 invoked by alias); 24 Jan 2017 15:23:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129584 invoked by uid 89); 24 Jan 2017 15:23:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy==e5=b0=a7, H*r:AES128-SHA?= X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 15:23:48 +0000 Received: by mail-wm0-f66.google.com with SMTP id c85so35301066wmi.1 for ; Tue, 24 Jan 2017 07:23:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=G5vnsOLNUQ6Wojg8ACBCEmbwM2tj22Ouf4MDoZr/d8I=; b=gVJThQiQp2UEWWpT2CNJeZIQMoS8JnobOgYFPCUYiUtu8gMyCDCvdXldTPwXUDpmRR DC6bJUFYjVEhY3/mHCDsF+guS0FHMCcBB22D9xGlAo/2pmIgpODJPEDMVOXkwnWfG+nI jHsuiOv0xEZ2CHvxgHYsocUdbm/VAwTBTq/d+wpSYO+QjNN/gxq7RD/4smYMZ9WAi62V loczYG4spO9QSHptjUJcJrQSy8Vmv1eNcOAWL1irG6L1ecMq5AWIRjqgmaBaNfdkylrz ZW3h3fccAMAr0l+3C3aR8jUx1jfun9dlMB/vsTn3aJxtfyCgCiuDKrEM+c8OI9UX5Ni9 fmPQ== X-Gm-Message-State: AIkVDXI7e8ReRmP/ALVC4FXiEOZI8SzwpVY1kZ/GAd9oyu1XrpeNBYDUL+rb/2hjn+5Pcw== X-Received: by 10.28.26.203 with SMTP id a194mr20686614wma.84.1485271426562; Tue, 24 Jan 2017 07:23:46 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 10sm20342720wrw.13.2017.01.24.07.23.44 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 Jan 2017 07:23:46 -0800 (PST) Date: Tue, 24 Jan 2017 15:23:00 -0000 From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Disassembly unit test: disassemble one instruction Message-ID: <20170124152326.GR28060@E107787-LIN> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-5-git-send-email-yao.qi@linaro.org> <620db0ef-5e3d-3b93-5596-33d24a78f6a9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <620db0ef-5e3d-3b93-5596-33d24a78f6a9@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00494.txt.bz2 On 17-01-20 00:03:48, Pedro Alves wrote: > > + /* Test gdb_disassembler for a given gdbarch by reading data from a > > + pre-allocated buffer. If you want to see the disassembled > > + instruction printed to gdb_stdout, set DISASSEMBLER_TEST_VERBOSE > > + to true. */ > > + > > + class gdb_disassembler_test : public gdb_disassembler > > + { > > + public: > > + > > + const bool DISASSEMBLER_TEST_VERBOSE = false; > > static. We give macros long unique names in order to > avoid naming conflicts, but if this is no longer a macro, > the name could be shortened, to e.g., just: > > static const bool verbose = false; > gdb_disassembler_test is a local class, so it can't have a static data member. I'll update patch to address your other comments. -- Yao (齐尧)