Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: palves@redhat.com, eliz@gnu.org, brobecker@adacore.com,
	       gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.
Date: Thu, 10 Nov 2016 12:37:00 -0000	[thread overview]
Message-ID: <20161110123701.GB25185@blade.nx> (raw)
In-Reply-To: <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com>

Walfred Tedeschi wrote:
> diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
> index bbce742..376ca9d 100755
> --- a/gdb/gdbserver/configure
> +++ b/gdb/gdbserver/configure
> @@ -7591,6 +7591,32 @@ _ACEOF
>  fi
>  
>  
> +# See if <sys/user.h> supports the %fs_base and %gs_bas amd64 segment registers.
> +# Older amd64 Linux's don't have the fs_base and gs_base members of
> +# `struct user_regs_struct'.

I'd mildly prefer to see these comments wrapped at 72 columns, but
I know the rules are different in autoconf files so please don't
consider this a blocker.

Thanks,
Gary

-- 
http://gbenson.net/


  parent reply	other threads:[~2016-11-10 12:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03  9:47 [PATCH 0/2] amd64: add fs_base and gs_base Walfred Tedeschi
2016-11-03  9:47 ` [PATCH 2/2] amd64-linux: expose system register FS_BASE and GS_BASE for Linux Walfred Tedeschi
2016-11-05 14:55   ` John Baldwin
2016-11-07 14:40     ` Tedeschi, Walfred
2016-11-10 12:36   ` Gary Benson
2016-11-30 13:31     ` Tedeschi, Walfred
2016-11-23 12:02   ` Pedro Alves
2016-11-30 10:29     ` Tedeschi, Walfred
2016-12-07 16:37       ` Pedro Alves
     [not found] ` <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com>
2016-11-10 12:37   ` Gary Benson [this message]
2016-11-23 12:02     ` [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver Pedro Alves
2016-11-30 14:20 ` [PATCH 0/2] amd64: add fs_base and gs_base Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110123701.GB25185@blade.nx \
    --to=gbenson@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox