From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17532 invoked by alias); 10 Nov 2016 12:37:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17522 invoked by uid 89); 10 Nov 2016 12:37:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=blocker, Hx-languages-length:704, linuxs, amd64 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Nov 2016 12:37:04 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B83A61BA3; Thu, 10 Nov 2016 12:37:03 +0000 (UTC) Received: from blade.nx (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAACb2QG002458; Thu, 10 Nov 2016 07:37:02 -0500 Received: by blade.nx (Postfix, from userid 1000) id 05F5C801A2C1; Thu, 10 Nov 2016 12:37:01 +0000 (GMT) Date: Thu, 10 Nov 2016 12:37:00 -0000 From: Gary Benson To: Walfred Tedeschi Cc: palves@redhat.com, eliz@gnu.org, brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver. Message-ID: <20161110123701.GB25185@blade.nx> References: <1478166445-21370-1-git-send-email-walfred.tedeschi@intel.com> <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00245.txt.bz2 Walfred Tedeschi wrote: > diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure > index bbce742..376ca9d 100755 > --- a/gdb/gdbserver/configure > +++ b/gdb/gdbserver/configure > @@ -7591,6 +7591,32 @@ _ACEOF > fi > > > +# See if supports the %fs_base and %gs_bas amd64 segment registers. > +# Older amd64 Linux's don't have the fs_base and gs_base members of > +# `struct user_regs_struct'. I'd mildly prefer to see these comments wrapped at 72 columns, but I know the rules are different in autoconf files so please don't consider this a blocker. Thanks, Gary -- http://gbenson.net/