From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: uweigand@de.ibm.com (Ulrich Weigand)
Cc: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya),
gdb-patches@sourceware.org
Subject: Re: set sysroot command on AIX has no effect.
Date: Tue, 11 Oct 2016 07:17:00 -0000 [thread overview]
Message-ID: <20161011071648.C875B10BCC0@oc8523832656.ibm.com> (raw)
In-Reply-To: <20161010162853.BEB9D10C212@oc8523832656.ibm.com> from "Ulrich Weigand" at Oct 10, 2016 06:28:53 PM
I wrote:
> This is looking mostly good. The one thing I don't like is all the extra
> xfree calls. I think a better way would to not actually xstrdup the found
> pathname early after all, but instead just get it from the BFD. So instead
> of the original:
>
> xfree (bfd_get_filename (object_bfd));
> object_bfd->filename = xstrdup (pathname);
>
> you'd do something like:
>
> object_bfd->filename = xrealloc (object_bfd->filename, ...);
> strcat (object_bfd->filename, sep);
Sorry, I mixed up the two BFDs here, we need to get the pathname from
the archive_bfd, of coutse. So this would be something like:
xfree (bfd_get_filename (object_bfd));
object_bfd->filename = xstrprintf ("%s%s", bfd_get_filename (archive_bfd), sep);
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-10-11 7:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 9:05 Sangamesh Mallayya
2016-09-29 15:33 ` Ulrich Weigand
2016-09-30 14:15 ` Sangamesh Mallayya
2016-09-30 14:38 ` Ulrich Weigand
2016-10-04 13:19 ` Sangamesh Mallayya
2016-10-07 19:31 ` Ulrich Weigand
2016-10-08 13:15 ` Sangamesh Mallayya
2016-10-08 14:38 ` Ulrich Weigand
2016-10-10 12:11 ` Sangamesh Mallayya
2016-10-10 16:29 ` Ulrich Weigand
2016-10-11 7:17 ` Ulrich Weigand [this message]
2016-10-13 13:42 ` Sangamesh Mallayya
2016-10-13 14:03 ` Ulrich Weigand
2016-10-13 17:44 ` Sangamesh Mallayya
2016-10-14 13:13 ` Ulrich Weigand
[not found] <OFBAE0EEF6.511F8BA2-ON6525802D.00305F69-6525802D.0031DA2D@LocalDomain>
2016-09-27 11:39 ` Sangamesh Mallayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011071648.C875B10BCC0@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox