From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya)
Cc: gdb-patches@sourceware.org
Subject: Re: set sysroot command on AIX has no effect.
Date: Thu, 29 Sep 2016 15:33:00 -0000 [thread overview]
Message-ID: <20160929152251.639F511C2C8@oc8523832656.ibm.com> (raw)
In-Reply-To: <OFBAE0EEF6.511F8BA2-ON6525802D.00305F69-6525802D.0031DAB8@notes.na.collabserv.com> from "Sangamesh Mallayya" at Sep 13, 2016 09:04:34 AM
Sangamesh Mallaya wrote:
> set sysroot command on AIX has no effect if a program depends on shared
> library archives (.a).
Yes, that seems a bug.
> + /* If gdb_sysroot is set via set sysroot command,
> + then we need to prefix gdb_sysroot to shared library path */
> + /* .a shared library archives case */
> + if (gdb_sysroot != NULL && *gdb_sysroot != 0) {
> + sys_path = alloca (sizeof(gdb_sysroot)+strlen(pathname));
> + memset (sys_path, 0, sizeof(sys_path));
> + strcpy(sys_path, gdb_sysroot);
> + pathname = strcat (sys_path, pathname);
> + }
> + path_len = strlen (pathname);
This duplicates some of the logic in solib_find. It would be better
to avoid that duplication ...
Is there any reason why you cannot use solib_find / solib_bfd_fopen
to open the archive file, like solib_bfd_open does? This would ensure
we're always using the same search logic for .a files as for .so files.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-09-29 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 9:05 Sangamesh Mallayya
2016-09-29 15:33 ` Ulrich Weigand [this message]
2016-09-30 14:15 ` Sangamesh Mallayya
2016-09-30 14:38 ` Ulrich Weigand
2016-10-04 13:19 ` Sangamesh Mallayya
2016-10-07 19:31 ` Ulrich Weigand
2016-10-08 13:15 ` Sangamesh Mallayya
2016-10-08 14:38 ` Ulrich Weigand
2016-10-10 12:11 ` Sangamesh Mallayya
2016-10-10 16:29 ` Ulrich Weigand
2016-10-11 7:17 ` Ulrich Weigand
2016-10-13 13:42 ` Sangamesh Mallayya
2016-10-13 14:03 ` Ulrich Weigand
2016-10-13 17:44 ` Sangamesh Mallayya
2016-10-14 13:13 ` Ulrich Weigand
[not found] <OFBAE0EEF6.511F8BA2-ON6525802D.00305F69-6525802D.0031DA2D@LocalDomain>
2016-09-27 11:39 ` Sangamesh Mallayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929152251.639F511C2C8@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox