From: Mike Frysinger <vapier@gentoo.org>
To: Nick Clifton <nickc@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Commit: AArch64: Simulate scalar NEG and vector MUL
Date: Fri, 18 Mar 2016 13:27:00 -0000 [thread overview]
Message-ID: <20160318132718.GF6588@vapier.lan> (raw)
In-Reply-To: <87io0kt9lt.fsf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On 18 Mar 2016 09:32, Nick Clifton wrote:
> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD) \
is using all caps for arg names a normal style thing ?
> + do \
> + { \
> + if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \
shouldn't this be ELEMENT ? and be >= ?
> +#define SET_VEC_ELEMENT(REG, ELEMENT, VAL, FIELD, PRINTER) \
> + do \
> + { \
> + if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD)) \
>= ?
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-18 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 9:32 Nick Clifton
2016-03-18 13:27 ` Mike Frysinger [this message]
2016-03-18 14:26 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318132718.GF6588@vapier.lan \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox