From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130341-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 35567 invoked by alias); 18 Mar 2016 13:27:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 35547 invoked by uid 89); 18 Mar 2016 13:27:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=caps
X-HELO: smtp.gentoo.org
Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Mar 2016 13:27:20 +0000
Received: from vapier.lan (localhost [127.0.0.1])	by smtp.gentoo.org (Postfix) with SMTP id 387ED340D6E;	Fri, 18 Mar 2016 13:27:18 +0000 (UTC)
Date: Fri, 18 Mar 2016 13:27:00 -0000
From: Mike Frysinger <vapier@gentoo.org>
To: Nick Clifton <nickc@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Commit: AArch64: Simulate scalar NEG and vector MUL
Message-ID: <20160318132718.GF6588@vapier.lan>
Mail-Followup-To: Nick Clifton <nickc@redhat.com>,	gdb-patches@sourceware.org
References: <87io0kt9lt.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="hA47Z5c7pMOLFxYj"
Content-Disposition: inline
In-Reply-To: <87io0kt9lt.fsf@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg00327.txt.bz2


--hA47Z5c7pMOLFxYj
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-length: 460

On 18 Mar 2016 09:32, Nick Clifton wrote:
> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD)	   \

is using all caps for arg names a normal style thing ?

> +  do						   \
> +    {						   \
> +      if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \

shouldn't this be ELEMENT ?  and be >= ?

> +#define SET_VEC_ELEMENT(REG, ELEMENT, VAL, FIELD, PRINTER)	\
> +  do						   		\
> +    {								\
> +      if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD))			\

>= ?
-mike

--hA47Z5c7pMOLFxYj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-length: 819

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJW7AI2AAoJEEFjO5/oN/WBk8MP/30wrEgrEmcMAukmSx5mnRRf
w8F7Ss2cRcpQrB77/ZUkHibiQMd2EPvHjfxv0okyYw8DAafCEpozGG1phZAn0xTD
g/EWL4w7HqRxTG5sC5mSFZvKtV2TaUBC6+4vVrOhqGiVh0IxKTQy25aY4sfa1e8J
L2z9xq2c6V5uHHcvcUGJEw+cRbVYZlmoNtz+t4AMl0+UATU8J2l0Cad/eEZjlpHv
f5GLCVBzdvxkJqstdYz1gW6LiXarXI5qPsnR4PWlUBpGsVaNnUqtx/0eWOWymli/
r6QHCfxvyboxbmS4D/07exhWJfnRlbS6zTkYb8XylH2OaBpEwCouJStceB3j7FaQ
5JVK8JFtchIMJFn5Qf2DiZz6H0o85FGspY02MgXCjGcZdneDFKRLFgxm7MjKzo4W
5heJtp7D6J3D5RNMZX9sxnQbVBagFFyqHLCxuzi+xXBIullV270CRCqoGnc9wk66
U8Fv9nMo1bwWeqTBJcjbzS70fUx6cS8HbIJ+jkHwIetJsn7kfANuYqhoOvj6KZGk
vmViUBQuDsDHDQLLVRuGpgLCoMmVwoMs+vjheu56K5DwR9LA/4epbq/KAntNlUQs
TzXY/ELKJz/YBuAdmqbIFcAoKl2sSwqFb5LYEnFUPbIJ6p1vWTTDSHqTfHwDbIUn
xH693caiwEWpxDKUamqM
=ax50
-----END PGP SIGNATURE-----

--hA47Z5c7pMOLFxYj--