From: Mike Frysinger <vapier@gentoo.org>
To: Steve Ellcey <sellcey@imgtec.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: allow the inline configure option everywhere [committed]
Date: Tue, 12 Jan 2016 22:17:00 -0000 [thread overview]
Message-ID: <20160112221714.GK4894@vapier.lan> (raw)
In-Reply-To: <1452635249.29343.126.camel@ubuntu-sellcey>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
On 12 Jan 2016 13:47, Steve Ellcey wrote:
> On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote:
> > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order
> > to make the configure flag available. There's no real reason to not
> > allow this flag for all ports, so move it to the common sim macro.
> > This way we get standard behavior across all ports too.
>
> Before this patch was checked in (commit
> 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the
> target mips-mti-linux-gnu, sim was not built. After the change, it does
> get built
i'm fairly certain that is not the case. that commit did not change the
top level or the common sim configure at all, and the mips-specific change
did not impact whether it was built.
> (well, it tries to get built, it actually fails to build).
that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae.
i filed a bug for it here:
https://sourceware.org/bugzilla/show_bug.cgi?id=19441
> I am not sure if this change in behavior, trying to build sim, is
> intended or not. I can fix it easily enough by using --disable-sim on
> my configure but I just wanted to check to see if this change was
> intentional. I have never built sim for this target before because I
> use qemu for testing it. I only use GNU sim for testing the mips*elf
> targets.
when building for mips*, you've always had to use --disable-sim in order
to keep it from being built.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-12 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 8:41 Mike Frysinger
2016-01-12 21:47 ` Steve Ellcey
2016-01-12 22:17 ` Mike Frysinger [this message]
2016-01-12 23:10 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112221714.GK4894@vapier.lan \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=sellcey@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox