From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123100 invoked by alias); 12 Jan 2016 22:17:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123089 invoked by uid 89); 12 Jan 2016 22:17:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Jan 2016 22:17:15 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id BABDF340691; Tue, 12 Jan 2016 22:17:13 +0000 (UTC) Date: Tue, 12 Jan 2016 22:17:00 -0000 From: Mike Frysinger To: Steve Ellcey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: allow the inline configure option everywhere [committed] Message-ID: <20160112221714.GK4894@vapier.lan> Mail-Followup-To: Steve Ellcey , gdb-patches@sourceware.org References: <1452415259-1212-1-git-send-email-vapier@gentoo.org> <1452635249.29343.126.camel@ubuntu-sellcey> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UthUFkbMtH2ceUK2" Content-Disposition: inline In-Reply-To: <1452635249.29343.126.camel@ubuntu-sellcey> X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00242.txt.bz2 --UthUFkbMtH2ceUK2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1469 On 12 Jan 2016 13:47, Steve Ellcey wrote: > On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote: > > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order > > to make the configure flag available. There's no real reason to not > > allow this flag for all ports, so move it to the common sim macro. > > This way we get standard behavior across all ports too. >=20 > Before this patch was checked in (commit > 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the > target mips-mti-linux-gnu, sim was not built. After the change, it does > get built i'm fairly certain that is not the case. that commit did not change the top level or the common sim configure at all, and the mips-specific change did not impact whether it was built. > (well, it tries to get built, it actually fails to build). that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae. i filed a bug for it here: https://sourceware.org/bugzilla/show_bug.cgi?id=3D19441 > I am not sure if this change in behavior, trying to build sim, is > intended or not. I can fix it easily enough by using --disable-sim on > my configure but I just wanted to check to see if this change was > intentional. I have never built sim for this target before because I > use qemu for testing it. I only use GNU sim for testing the mips*elf > targets. when building for mips*, you've always had to use --disable-sim in order to keep it from being built. -mike --UthUFkbMtH2ceUK2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWlXtqAAoJEEFjO5/oN/WB9YEQALF/XsO8yH02mAleFPH4vuzF tziLeswqa4BmSQFYAeb5lCarGeCs/D0JOILy19CcOF9eZ6UbYegYMkjSN24KOg2k te7EB4tGj3ry/xOqxAWVrwTtLIUbVISfe0ftGDFz0DhfVFVMA9ZZCPWZL5e5GSSa fjNLXbNtsrygnoNi5XlR48afnB42MKB7iU9J9cRn6vA8aZmIgIlrUSAJJzKrLHk6 mWK/Z5RQ86NK2qAD76/sWLa4neGFBMJb/npHtDOJFWCwvNqm91dYalfxT6DGerCM 8JNFnewxy1uoMS2RE6THHLLgfY7ITFW9eOgH9IfUajp89iiNkuWisYOHD33toZhB ia8QuN84HNi+DLb1IhpJeyco/14AwLFPvN+C8sPh2V20CrHklLbNVqakP9vW6168 wZTCVnQEliOCILLCrfMAwSMzMnugLaHO+PC2f3mDzfllzuXw+BIxh45EJxSdR27i mghnReU1mkJE0aI9pv8Z/WBiQvVQJSlNKaN7TwC0wztCSsUaOkBJvUzQJ3xmHcQG 8w113JLPl275OOc/r8vzVzb6PqWRJTngNfQb55awV21o29dg0eKn3VpxSAe8qqrn gfQoGYwj6Yx8IBiu5zCZgmcmE/WJtUfDIeROn2D3VS2c3hK2a65ovBw0EJ4z/MFw F3tulsuIR1qexPfLHGjO =oWhX -----END PGP SIGNATURE----- --UthUFkbMtH2ceUK2--