From: Steve Ellcey <sellcey@imgtec.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: allow the inline configure option everywhere [committed]
Date: Tue, 12 Jan 2016 23:10:00 -0000 [thread overview]
Message-ID: <1452640246.29343.134.camel@ubuntu-sellcey> (raw)
In-Reply-To: <20160112221714.GK4894@vapier.lan>
On Tue, 2016-01-12 at 17:17 -0500, Mike Frysinger wrote:
> On 12 Jan 2016 13:47, Steve Ellcey wrote:
> > On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote:
> > > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order
> > > to make the configure flag available. There's no real reason to not
> > > allow this flag for all ports, so move it to the common sim macro.
> > > This way we get standard behavior across all ports too.
> >
> > Before this patch was checked in (commit
> > 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the
> > target mips-mti-linux-gnu, sim was not built. After the change, it does
> > get built
>
> i'm fairly certain that is not the case. that commit did not change the
> top level or the common sim configure at all, and the mips-specific change
> did not impact whether it was built.
OK, I see what was happening. I didn't think sim was getting built
because I wasn't building all-sim and install-sim and so there was no
mips-mti-linux-gnu-run in the install directory but the component was
still getting built as part of gdb.
> > (well, it tries to get built, it actually fails to build).
>
> that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae.
> i filed a bug for it here:
> https://sourceware.org/bugzilla/show_bug.cgi?id=19441
OK, with the old inline setting I wasn't seeing this and now I am, that
makes sense now. I'll ping Andrew about the bug and see about fixing
it.
Steve Ellcey
sellcey@imgtec.com
prev parent reply other threads:[~2016-01-12 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 8:41 Mike Frysinger
2016-01-12 21:47 ` Steve Ellcey
2016-01-12 22:17 ` Mike Frysinger
2016-01-12 23:10 ` Steve Ellcey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452640246.29343.134.camel@ubuntu-sellcey \
--to=sellcey@imgtec.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox