From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44982 invoked by alias); 12 Jan 2016 23:10:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44962 invoked by uid 89); 12 Jan 2016 23:10:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1579 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jan 2016 23:10:51 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Websense Email Security Gateway with ESMTPS id 6380C65FA2BDB; Tue, 12 Jan 2016 23:10:45 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 12 Jan 2016 23:10:48 +0000 Received: from [10.20.3.214] (10.20.3.214) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 12 Jan 2016 15:10:46 -0800 Message-ID: <1452640246.29343.134.camel@ubuntu-sellcey> Subject: Re: [PATCH] sim: allow the inline configure option everywhere [committed] From: Steve Ellcey Reply-To: To: Mike Frysinger CC: Date: Tue, 12 Jan 2016 23:10:00 -0000 In-Reply-To: <20160112221714.GK4894@vapier.lan> References: <1452415259-1212-1-git-send-email-vapier@gentoo.org> <1452635249.29343.126.camel@ubuntu-sellcey> <20160112221714.GK4894@vapier.lan> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2016-01/txt/msg00245.txt.bz2 On Tue, 2016-01-12 at 17:17 -0500, Mike Frysinger wrote: > On 12 Jan 2016 13:47, Steve Ellcey wrote: > > On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote: > > > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order > > > to make the configure flag available. There's no real reason to not > > > allow this flag for all ports, so move it to the common sim macro. > > > This way we get standard behavior across all ports too. > > > > Before this patch was checked in (commit > > 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the > > target mips-mti-linux-gnu, sim was not built. After the change, it does > > get built > > i'm fairly certain that is not the case. that commit did not change the > top level or the common sim configure at all, and the mips-specific change > did not impact whether it was built. OK, I see what was happening. I didn't think sim was getting built because I wasn't building all-sim and install-sim and so there was no mips-mti-linux-gnu-run in the install directory but the component was still getting built as part of gdb. > > (well, it tries to get built, it actually fails to build). > > that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae. > i filed a bug for it here: > https://sourceware.org/bugzilla/show_bug.cgi?id=19441 OK, with the old inline setting I wasn't seeing this and now I am, that makes sense now. I'll ping Andrew about the bug and see about fixing it. Steve Ellcey sellcey@imgtec.com