Re: [PATCH] gdb: sim: disable integration w/some multitarget configs [PR sim/13418]

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]

On 04 Jan 2016 13:38, Pedro Alves wrote:
> On 01/02/2016 08:42 AM, Mike Frysinger wrote:
> > Multitarget builds currently fail when:
> > (1) simulator support is enabled
> > (2) powerpc is included in the target list
> > (3) powerpc is not the main/default target
> > 
> > This is because the powerpc sim provides a non-standard API function
> > sim_spr_register_name which the powerpc gdb utilizes.  Since the sim
> > does not yet support multitarget, only the sim for the main target
> > (if one exists) is built.  When that target isn't powerpc, this func
> > is not available leading to linking errors.
> > 
> > Since multitarget support is going to take a while, and specifically
> > the powerpc target is going to take even longer, disable sim support
> > automatically when the aforementioned conditions are met.
> 
> > diff --git a/gdb/configure.ac b/gdb/configure.ac
> > index 5b618c9..458605f 100644
> > --- a/gdb/configure.ac
> > +++ b/gdb/configure.ac
> > @@ -2256,6 +2256,19 @@ fi
> >  SIM=
> >  SIM_OBS=
> >  if test "${ignore_sim}" = "false"; then
> > +  # The ppc gdb/sim only works when it's the main target.  PR sim/13418
> > +  case $target in
> > +  powerpc*-*-*) ;;
> > +  *)
> > +    case "${all_targets}: ${TARGET_OBS} " in
> > +    true:*|*" rs6000-tdep.o "*)
> > +      AC_MSG_WARN([Disabling sim integration for multitarget powerpc configs])
> > +      gdb_sim=
> > +      ;;
> > +    esac
> > +    ;;
> > +  esac
> > +
> 
> Now sure about that.  It penalizes non-PPC sims for a PPC sim issue.
> 
> How about this instead?

i'm fine with this, so lgtm
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]