From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19663 invoked by alias); 5 Jan 2016 00:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19646 invoked by uid 89); 5 Jan 2016 00:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Jan 2016 00:55:54 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 1587E33E142; Tue, 5 Jan 2016 00:55:46 +0000 (UTC) Date: Tue, 05 Jan 2016 00:55:00 -0000 From: Mike Frysinger To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: sim: disable integration w/some multitarget configs [PR sim/13418] Message-ID: <20160105005552.GG25548@vapier.lan> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <1451724153-23316-1-git-send-email-vapier@gentoo.org> <568A75CE.1010007@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sClP8c1IaQxyux9v" Content-Disposition: inline In-Reply-To: <568A75CE.1010007@redhat.com> X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00042.txt.bz2 --sClP8c1IaQxyux9v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1604 On 04 Jan 2016 13:38, Pedro Alves wrote: > On 01/02/2016 08:42 AM, Mike Frysinger wrote: > > Multitarget builds currently fail when: > > (1) simulator support is enabled > > (2) powerpc is included in the target list > > (3) powerpc is not the main/default target > >=20 > > This is because the powerpc sim provides a non-standard API function > > sim_spr_register_name which the powerpc gdb utilizes. Since the sim > > does not yet support multitarget, only the sim for the main target > > (if one exists) is built. When that target isn't powerpc, this func > > is not available leading to linking errors. > >=20 > > Since multitarget support is going to take a while, and specifically > > the powerpc target is going to take even longer, disable sim support > > automatically when the aforementioned conditions are met. >=20 > > diff --git a/gdb/configure.ac b/gdb/configure.ac > > index 5b618c9..458605f 100644 > > --- a/gdb/configure.ac > > +++ b/gdb/configure.ac > > @@ -2256,6 +2256,19 @@ fi > > SIM=3D > > SIM_OBS=3D > > if test "${ignore_sim}" =3D "false"; then > > + # The ppc gdb/sim only works when it's the main target. PR sim/13418 > > + case $target in > > + powerpc*-*-*) ;; > > + *) > > + case "${all_targets}: ${TARGET_OBS} " in > > + true:*|*" rs6000-tdep.o "*) > > + AC_MSG_WARN([Disabling sim integration for multitarget powerpc c= onfigs]) > > + gdb_sim=3D > > + ;; > > + esac > > + ;; > > + esac > > + >=20 > Now sure about that. It penalizes non-PPC sims for a PPC sim issue. >=20 > How about this instead? i'm fine with this, so lgtm -mike --sClP8c1IaQxyux9v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWixSXAAoJEEFjO5/oN/WBX9QP/1zuVOAiLYrNYFf18XMntij5 OFnGtbOaKqppBHGDkO8sFt3kmkFFahuISivcxlxReBf8a7xABFd6o4hk9IYxj3Ij tjyrsMQa33WQ5rWbmOkBSqzQcVC3Xh2kGSiYgw8yhZjUTvSEHS2yMX4kaRs2bguh i0p10JnPTXrl3q4EsayHWoTkhtcNTzH2Ervm8AowfD61UG22hvDHWVIJ30EypdYh HHoG7YeU/RmaBEhLlv6l/SeektQZksOOXrcxLt8aPA+747p3eCAuPCEDj5LjoRL2 eIUBB7IVFxbvVK1bneiGrLI5dchC8vg9I41AVYocTJI9+tfc8l5LBMYH36i8NhIH mTW0zy4Sa/rGlTv2XiG6sn12P65speKWnfHbhsft8mGCdHyOOfVEVZN30jZeTuNf kNF8LJjB4MXZ+AXKCYVawqeQa+tq+3rHOZu9K/9gS4m6pLh1rLAEaZGAvkEYNLX5 Aw4uKYJA94I/IEeqaWWz5rLLN7bh5lDuDd4DhfRrL9tPaaXB0jtl+J4G7xo6tc7/ fFfFk/K80hLlgEhv3EQ8OBe+qkbYcWNPtIH4s0f7clYLL5RoibQ2hFuG3Jc7aQyU u+8YmRMQ3ACKcvFKEnBMrh470fet9WcRMEbVaX5RECek/4Xe8JvTX0CHQvEZlKg3 +UgwzjfV3GI8gp517++q =JYu3 -----END PGP SIGNATURE----- --sClP8c1IaQxyux9v--