From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb: sim: disable integration w/some multitarget configs [PR sim/13418]
Date: Sat, 02 Jan 2016 08:42:00 -0000 [thread overview]
Message-ID: <1451724153-23316-1-git-send-email-vapier@gentoo.org> (raw)
Multitarget builds currently fail when:
(1) simulator support is enabled
(2) powerpc is included in the target list
(3) powerpc is not the main/default target
This is because the powerpc sim provides a non-standard API function
sim_spr_register_name which the powerpc gdb utilizes. Since the sim
does not yet support multitarget, only the sim for the main target
(if one exists) is built. When that target isn't powerpc, this func
is not available leading to linking errors.
Since multitarget support is going to take a while, and specifically
the powerpc target is going to take even longer, disable sim support
automatically when the aforementioned conditions are met.
2016-01-02 Mike Frysinger <vapier@gentoo.org>
PR sim/13418
* configure.ac: Set gdb_sim= when target is not powerpc*, and
all_targets is true or rs6000-tdep.o is in TARGET_OBS.
* configure: Regenerate.
---
gdb/configure | 14 ++++++++++++++
gdb/configure.ac | 13 +++++++++++++
2 files changed, 27 insertions(+)
diff --git a/gdb/configure b/gdb/configure
index 5afdbbc..57c1ea7 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -15840,6 +15840,20 @@ fi
SIM=
SIM_OBS=
if test "${ignore_sim}" = "false"; then
+ # The ppc gdb/sim only works when it's the main target. PR sim/13418
+ case $target in
+ powerpc*-*-*) ;;
+ *)
+ case "${all_targets}: ${TARGET_OBS} " in
+ true:*|*" rs6000-tdep.o "*)
+ { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Disabling sim integration for multitarget powerpc configs" >&5
+$as_echo "$as_me: WARNING: Disabling sim integration for multitarget powerpc configs" >&2;}
+ gdb_sim=
+ ;;
+ esac
+ ;;
+ esac
+
if test x"${gdb_sim}" != x ; then
SIM="${gdb_sim}"
SIM_OBS="remote-sim.o"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 5b618c9..458605f 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -2256,6 +2256,19 @@ fi
SIM=
SIM_OBS=
if test "${ignore_sim}" = "false"; then
+ # The ppc gdb/sim only works when it's the main target. PR sim/13418
+ case $target in
+ powerpc*-*-*) ;;
+ *)
+ case "${all_targets}: ${TARGET_OBS} " in
+ true:*|*" rs6000-tdep.o "*)
+ AC_MSG_WARN([Disabling sim integration for multitarget powerpc configs])
+ gdb_sim=
+ ;;
+ esac
+ ;;
+ esac
+
if test x"${gdb_sim}" != x ; then
SIM="${gdb_sim}"
SIM_OBS="remote-sim.o"
--
2.6.2
next reply other threads:[~2016-01-02 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 8:42 Mike Frysinger [this message]
2016-01-04 13:38 ` Pedro Alves
2016-01-05 0:55 ` Mike Frysinger
2016-01-05 11:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451724153-23316-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox