From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported"
Date: Tue, 08 Dec 2015 08:01:00 -0000 [thread overview]
Message-ID: <20151208080124.GA2712@adacore.com> (raw)
In-Reply-To: <20151207232255.15b0c35e@pinnacle.lan>
Hi Kevin,
> gdb/testsuite/ChangeLog:
>
> * gdb.base/async.exp (proc test_background): Add case
> for asynchronous execution not supported.
You might want to escape the period you're trying to match
at the end of the sentence. Other than that, LGTM.
Looking at this, would it be possible in this case to replace
the send_gdb/gdb_expect into test_gdb_multiple? I'm not really
sure, because of the async nature makes ordering of the output
relative to the gdb_prompt different from usual, and thus perhaps
outside the scope of what test_gdb_multiple is capable of doing...
Thanks!
> ---
> gdb/testsuite/gdb.base/async.exp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/async.exp
> index 2d3fb73..8226244 100644
> --- a/gdb/testsuite/gdb.base/async.exp
> +++ b/gdb/testsuite/gdb.base/async.exp
> @@ -61,6 +61,9 @@ proc test_background {command before_prompt after_prompt {message ""}} {
> -re "$gdb_prompt.*completed\.\r\n" {
> fail "$message"
> }
> + -re ".*Asynchronous execution not supported on this target..*" {
> + unsupported "Asynchronous execution not supported: $message"
> + }
> timeout {
> fail "$message (timeout)"
> }
--
Joel
next prev parent reply other threads:[~2015-12-08 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 6:23 Kevin Buettner
2015-12-08 8:01 ` Joel Brobecker [this message]
2015-12-08 20:17 ` Kevin Buettner
2015-12-09 10:13 ` Pedro Alves
2015-12-09 16:28 ` Kevin Buettner
2015-12-08 10:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208080124.GA2712@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox