From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117012 invoked by alias); 8 Dec 2015 08:01:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117001 invoked by uid 89); 8 Dec 2015 08:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 08 Dec 2015 08:01:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D7265116687; Tue, 8 Dec 2015 03:01:25 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5PRnnMD+87ep; Tue, 8 Dec 2015 03:01:25 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B177C116563; Tue, 8 Dec 2015 03:01:25 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 45CD5406C6; Tue, 8 Dec 2015 09:01:24 +0100 (CET) Date: Tue, 08 Dec 2015 08:01:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported" Message-ID: <20151208080124.GA2712@adacore.com> References: <20151207232255.15b0c35e@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151207232255.15b0c35e@pinnacle.lan> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-12/txt/msg00150.txt.bz2 Hi Kevin, > gdb/testsuite/ChangeLog: > > * gdb.base/async.exp (proc test_background): Add case > for asynchronous execution not supported. You might want to escape the period you're trying to match at the end of the sentence. Other than that, LGTM. Looking at this, would it be possible in this case to replace the send_gdb/gdb_expect into test_gdb_multiple? I'm not really sure, because of the async nature makes ordering of the output relative to the gdb_prompt different from usual, and thus perhaps outside the scope of what test_gdb_multiple is capable of doing... Thanks! > --- > gdb/testsuite/gdb.base/async.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/async.exp > index 2d3fb73..8226244 100644 > --- a/gdb/testsuite/gdb.base/async.exp > +++ b/gdb/testsuite/gdb.base/async.exp > @@ -61,6 +61,9 @@ proc test_background {command before_prompt after_prompt {message ""}} { > -re "$gdb_prompt.*completed\.\r\n" { > fail "$message" > } > + -re ".*Asynchronous execution not supported on this target..*" { > + unsupported "Asynchronous execution not supported: $message" > + } > timeout { > fail "$message (timeout)" > } -- Joel