Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported"
Date: Wed, 09 Dec 2015 10:13:00 -0000	[thread overview]
Message-ID: <5667FEB3.9050601@redhat.com> (raw)
In-Reply-To: <20151208131702.00048638@pinnacle.lan>

On 12/08/2015 08:17 PM, Kevin Buettner wrote:
> On Tue, 8 Dec 2015 09:01:24 +0100
> Joel Brobecker <brobecker@adacore.com> wrote:
> 
>> You might want to escape the period you're trying to match
>> at the end of the sentence. Other than that, LGTM.
> 
> Fixed in new patch.  (See below.)
> 
> I've addressed Pedro's concerns too.
> 

Thanks, LGTM.

>> Looking at this, would it be possible in this case to replace
>> the send_gdb/gdb_expect into test_gdb_multiple? I'm not really
>> sure, because of the async nature makes ordering of the output
>> relative to the gdb_prompt different from usual, and thus perhaps
>> outside the scope of what test_gdb_multiple is capable of doing...
> 
> I don't know the answer to this either.  I'll defer to someone
> who knows more about this than I do.

I think I recall trying gdb_test_multiple for 884e37dc, but not sure.
The prompt matching within gdb_test_multiple will definitely be the
thing to watch out for.

> 
> Here's an updated patch...
> 

Thanks,
Pedro Alves


  reply	other threads:[~2015-12-09 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  6:23 Kevin Buettner
2015-12-08  8:01 ` Joel Brobecker
2015-12-08 20:17   ` Kevin Buettner
2015-12-09 10:13     ` Pedro Alves [this message]
2015-12-09 16:28       ` Kevin Buettner
2015-12-08 10:01 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5667FEB3.9050601@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox