From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: koriakin@0x04.net (Marcin Kościelnicki)
Cc: gdb-patches@sourceware.org, koriakin@0x04.net (Marcin Kościelnicki)
Subject: Re: [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.
Date: Mon, 02 Nov 2015 20:41:00 -0000 [thread overview]
Message-ID: <20151102204134.2A0792665@oc7340732750.ibm.com> (raw)
In-Reply-To: <1446491482-3703-3-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 02, 2015 08:11:22 PM
Marcin KoÅcielnicki <koriakin at 0x04 dot net> wrote:
> +static int
> +s390_is_partial_instruction (CORE_ADDR loc, int *len)
> +{
> + uint16_t insn;
> +
> + insn = read_memory_integer (loc, 2, BFD_ENDIAN_BIG);
See the comment in the other patch about avoiding hard-coding
BFD_ENDIAN_BIG ...
As mentioned, it would be preferable to enable this only
when recording is on.
Otherwise, this patch looks good.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-11-02 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 14:32 [RFC][PATCH][PR 18376] gdb: Add process record and replay support for s390 Marcin Kościelnicki
2015-10-30 15:30 ` Ulrich Weigand
2015-10-30 15:44 ` Marcin Kościelnicki
2015-10-30 15:56 ` Ulrich Weigand
2015-11-02 19:11 ` Marcin Kościelnicki
2015-11-02 19:11 ` [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit Marcin Kościelnicki
2015-11-02 20:41 ` Ulrich Weigand [this message]
2015-11-03 15:49 ` [PATCH v3 " Marcin Kościelnicki
2015-11-03 16:13 ` Ulrich Weigand
2015-11-03 16:44 ` Marcin Kościelnicki
2015-11-03 17:34 ` Ulrich Weigand
2015-11-02 19:29 ` [PATCH 1/2] gdb: Add process record and replay support for s390 Marcin Kościelnicki
2015-11-02 20:35 ` Ulrich Weigand
2015-11-03 13:56 ` [PATCH v3 " Marcin Kościelnicki
2015-11-03 14:17 ` Ulrich Weigand
2015-11-02 20:33 ` [RFC][PATCH][PR 18376] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102204134.2A0792665@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox