From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: uweigand@de.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][PATCH][PR 18376] gdb: Add process record and replay support for s390.
Date: Mon, 02 Nov 2015 19:11:00 -0000 [thread overview]
Message-ID: <1446491482-3703-1-git-send-email-koriakin@0x04.net> (raw)
In-Reply-To: <20151030103938.99AE45C3D@oc7340732750.ibm.com>
Here comes v2.
I have added pseudo-support for TBEGIN (just to let it abort and fallback),
as well as PPA and ETND (on the off-chance someone uses them).
I have also found three missing break statements and fixed those.
The second patch implements single-stepping over a MVCLE+JO pair (as well
as other partial-execution instructions that can write memory). I haven't
limitted it to record-only - AFAICT it doesn't cause any problems without
record (in fact, it should decrease context switches for large transfers),
but I'll restrict that if necessary.
As for the Uniersity of Syracuse machines, I do have access, and they are
only z196.
There's also an ambiguity in LCBB opcode documentation: it produces a 32-bit
unsigned result, but the text mentions storing it to the general register
(not to bits 32-63 of a general register, as is common for documentation
of proper 32-bit opcodes). I don't have a vector-supporting machine, so
I can't check what is correct. The patch goes the safe way and assumes
all 64 bits of GR can be changed.
next prev parent reply other threads:[~2015-11-02 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 14:32 Marcin Kościelnicki
2015-10-30 15:30 ` Ulrich Weigand
2015-10-30 15:44 ` Marcin Kościelnicki
2015-10-30 15:56 ` Ulrich Weigand
2015-11-02 19:11 ` Marcin Kościelnicki [this message]
2015-11-02 19:11 ` [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit Marcin Kościelnicki
2015-11-02 20:41 ` Ulrich Weigand
2015-11-03 15:49 ` [PATCH v3 " Marcin Kościelnicki
2015-11-03 16:13 ` Ulrich Weigand
2015-11-03 16:44 ` Marcin Kościelnicki
2015-11-03 17:34 ` Ulrich Weigand
2015-11-02 19:29 ` [PATCH 1/2] gdb: Add process record and replay support for s390 Marcin Kościelnicki
2015-11-02 20:35 ` Ulrich Weigand
2015-11-03 13:56 ` [PATCH v3 " Marcin Kościelnicki
2015-11-03 14:17 ` Ulrich Weigand
2015-11-02 20:33 ` [RFC][PATCH][PR 18376] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446491482-3703-1-git-send-email-koriakin@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox