From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1717 invoked by alias); 2 Nov 2015 20:41:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1684 invoked by uid 89); 2 Nov 2015 20:41:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp17.uk.ibm.com Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 02 Nov 2015 20:41:41 +0000 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Nov 2015 20:41:38 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 2 Nov 2015 20:41:36 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D8D552190046 for ; Mon, 2 Nov 2015 20:41:31 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA2KfZJs5177682 for ; Mon, 2 Nov 2015 20:41:35 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA2KfZar010410 for ; Mon, 2 Nov 2015 13:41:35 -0700 Received: from oc7340732750.ibm.com (icon-9-164-158-208.megacenter.de.ibm.com [9.164.158.208]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA2KfYY0010403; Mon, 2 Nov 2015 13:41:35 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 2A0792665; Mon, 2 Nov 2015 21:41:34 +0100 (CET) Subject: Re: [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Mon, 02 Nov 2015 20:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1446491482-3703-3-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 02, 2015 08:11:22 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20151102204134.2A0792665@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110220-0029-0000-0000-000008ED4C2F X-SW-Source: 2015-11/txt/msg00048.txt.bz2 Marcin KoÅcielnicki wrote: > +static int > +s390_is_partial_instruction (CORE_ADDR loc, int *len) > +{ > + uint16_t insn; > + > + insn = read_memory_integer (loc, 2, BFD_ENDIAN_BIG); See the comment in the other patch about avoiding hard-coding BFD_ENDIAN_BIG ... As mentioned, it would be preferable to enable this only when recording is on. Otherwise, this patch looks good. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com