From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: antoine.tremblay@ericsson.com (Antoine Tremblay)
Cc: gdb-patches@sourceware.org,
antoine.tremblay@ericsson.com (Antoine Tremblay),
palves@redhat.com
Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer.
Date: Thu, 22 Oct 2015 15:17:00 -0000 [thread overview]
Message-ID: <20151022134952.1AF5AF738@oc7340732750.ibm.com> (raw)
In-Reply-To: <1445359685-2589-3-git-send-email-antoine.tremblay@ericsson.com> from "Antoine Tremblay" at Oct 20, 2015 12:48:02 PM
Antoine Tremblay wrote:
> gdb/gdbserver/ChangeLog:
> * mem-break.c : Remove breakpoint_data/breakpoint_len global variables.
> (set_breakpoint_data): Remove.
This breaks building gdbserver for spu-elf:
spu-low.o: In function `initialize_low':
gdb/gdbserver/spu-low.c:684: undefined reference to `set_breakpoint_data'
and most likely other non-Linux gdbserver targets that still refer to
set_breakpoint_data:
gdb/gdbserver/nto-low.c: set_breakpoint_data (the_low_target.breakpoint,
gdb/gdbserver/win32-low.c: set_breakpoint_data (the_low_target.breakpoint,
What needs to be done to fix those?
B.t.w. if set_breakpoint_data is really gone, its prototype should be
removed from mem-break.h as well.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-10-22 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 16:48 [PATCH v3 0/5] Software breakpoints support for ARM linux " Antoine Tremblay
2015-10-20 16:48 ` [PATCH v3 5/5] Support software breakpoints " Antoine Tremblay
2015-10-21 13:12 ` Pedro Alves
2015-10-20 16:48 ` [PATCH v3 1/5] Add the target_ops needed for software breakpoints " Antoine Tremblay
2015-10-21 11:22 ` Pedro Alves
2015-10-20 16:49 ` [PATCH v3 4/5] Refactor the breakpoint definitions in linux-arm-low.c Antoine Tremblay
2015-10-21 13:04 ` Pedro Alves
2015-10-20 16:49 ` [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer Antoine Tremblay
2015-10-21 11:49 ` Pedro Alves
2015-10-21 14:19 ` Antoine Tremblay
2015-10-21 14:23 ` Pedro Alves
2015-10-21 14:41 ` Antoine Tremblay
2015-10-22 15:17 ` Ulrich Weigand [this message]
2015-10-22 15:54 ` Antoine Tremblay
2015-10-20 16:55 ` [PATCH v3 3/5] Implement breakpoint_kind_from_pc and sw_breakpoint_from_kind for ARM " Antoine Tremblay
2015-10-21 12:04 ` Pedro Alves
2015-10-21 13:34 ` [PATCH v3 0/5] Software breakpoints support for ARM linux " Pedro Alves
2015-10-21 18:44 ` Yao Qi
2015-10-21 19:31 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022134952.1AF5AF738@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox